Skip to content

Commit 91ee536

Browse files
committed
Renamed some datetime fields from 'time' to 'modified', to match their semantics, and changed them to use auto_now=True. This should fix an issue with outdated timestamps on some meeting-related objects.
- Legacy-Id: 14724
1 parent 5573dc0 commit 91ee536

3 files changed

Lines changed: 39 additions & 4 deletions

File tree

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
# -*- coding: utf-8 -*-
2+
# Generated by Django 1.11.10 on 2018-03-02 14:33
3+
from __future__ import unicode_literals
4+
5+
from django.db import migrations, models
6+
7+
8+
class Migration(migrations.Migration):
9+
10+
dependencies = [
11+
('meeting', '0002_auto_20180225_1207'),
12+
]
13+
14+
operations = [
15+
migrations.RenameField(
16+
model_name='floorplan',
17+
old_name='time',
18+
new_name='modified',
19+
),
20+
migrations.RenameField(
21+
model_name='room',
22+
old_name='time',
23+
new_name='modified',
24+
),
25+
migrations.AlterField(
26+
model_name='floorplan',
27+
name='modified',
28+
field=models.DateTimeField(auto_now=True),
29+
),
30+
migrations.AlterField(
31+
model_name='room',
32+
name='modified',
33+
field=models.DateTimeField(auto_now=True),
34+
),
35+
]

ietf/meeting/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ def json_dict(self, host_scheme):
302302

303303
class Room(models.Model):
304304
meeting = ForeignKey(Meeting)
305-
time = models.DateTimeField(default=datetime.datetime.now)
305+
modified = models.DateTimeField(auto_now=True)
306306
name = models.CharField(max_length=255)
307307
functional_name = models.CharField(max_length=255, blank = True)
308308
capacity = models.IntegerField(null=True, blank=True)
@@ -392,7 +392,7 @@ def floorplan_path(instance, filename):
392392
class FloorPlan(models.Model):
393393
name = models.CharField(max_length=255)
394394
short = models.CharField(max_length=3, default='')
395-
time = models.DateTimeField(default=datetime.datetime.now)
395+
modified= models.DateTimeField(auto_now=True)
396396
meeting = ForeignKey(Meeting)
397397
order = models.SmallIntegerField()
398398
image = models.ImageField(storage=NoLocationMigrationFileSystemStorage(), upload_to=floorplan_path, blank=True, default=None)

ietf/meeting/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -964,10 +964,10 @@ def json_agenda(request, num=None ):
964964
if room.x1 is not None:
965965
roomdict['x'] = (room.x1+room.x2)/2.0
966966
roomdict['y'] = (room.y1+room.y2)/2.0
967-
roomdict['modified'] = room.time
967+
roomdict['modified'] = room.modified
968968
if room.floorplan and room.floorplan.image:
969969
roomdict['map'] = room.floorplan.image.url
970-
roomdict['modified'] = max(room.time,room.floorplan.time)
970+
roomdict['modified'] = max(room.modified, room.floorplan.modified)
971971
rooms.append(roomdict)
972972

973973
parents = []

0 commit comments

Comments
 (0)