Skip to content

Commit 90e46a0

Browse files
committed
Get rid of a couple of FIXMEs
- Legacy-Id: 2825
1 parent e9236da commit 90e46a0

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

ietf/idrfc/views_search.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,6 @@ class SearchForm(forms.Form):
270270
group = forms.CharField(required=False)
271271
area = forms.ModelChoiceField(Group.objects.filter(type="area", state="active").order_by('name'), empty_label="any area", required=False)
272272
ad = forms.ChoiceField(choices=(), required=False)
273-
# FIXME: state needs a sort
274273
state = forms.ModelChoiceField(IesgDocStateName.objects.all(), empty_label="any state", required=False)
275274
subState = forms.ChoiceField(choices=(), required=False)
276275

@@ -288,8 +287,7 @@ def __init__(self, *args, **kwargs):
288287
active_ads.sort(key=extract_last_name)
289288
inactive_ads.sort(key=extract_last_name)
290289

291-
# FIXME: -99
292-
self.fields['ad'].choices = c = [('', 'any AD')] + [(ad.pk, ad.get_name()) for ad in active_ads] + [('-99', '------------------')] + [(ad.pk, ad.get_name()) for ad in inactive_ads]
290+
self.fields['ad'].choices = c = [('', 'any AD')] + [(ad.pk, ad.get_name()) for ad in active_ads] + [('', '------------------')] + [(ad.pk, ad.get_name()) for ad in inactive_ads]
293291
self.fields['subState'].choices = [('', 'any substate'), ('0', 'no substate')] + [(n.slug, n.name) for n in DocInfoTagName.objects.filter(slug__in=('point', 'ad-f-up', 'need-rev', 'extpty'))]
294292
def clean_name(self):
295293
value = self.cleaned_data.get('name','')
@@ -322,7 +320,7 @@ def search_query(query_original):
322320

323321
# Non-ASCII strings don't match anything; this check
324322
# is currently needed to avoid complaints from MySQL.
325-
# FIXME: this should be fixed if it's still a problem
323+
# FIXME: this should be fixed with MySQL if it's still a problem?
326324
for k in ['name','author','group']:
327325
try:
328326
tmp = str(query.get(k, ''))

0 commit comments

Comments
 (0)