Skip to content

Commit 90428d6

Browse files
committed
Moved hard coded defaults for max items to show and days to show to
the settings.py. Commit ready for merge. - Legacy-Id: 17083
1 parent c41e5b5 commit 90428d6

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

ietf/group/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,8 +1402,8 @@ def reviewer_overview(request, acronym, group_type=None):
14021402

14031403
today = datetime.date.today()
14041404

1405-
max_closed_reqs = 10
1406-
days_back = 365
1405+
max_closed_reqs = settings.GROUP_REVIEW_MAX_ITEMS_TO_SHOW_IN_REVIEWER_LIST
1406+
days_back = settings.GROUP_REVIEW_DAYS_TO_SHOW_IN_REVIEWER_LIST
14071407
if can_manage:
14081408
secretary_settings = (ReviewSecretarySettings.objects.filter(person=
14091409
request.user.person,

ietf/settings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,10 @@ def skip_unreadable_post(record):
591591
GROUP_STATES_WITH_EXTRA_PROCESSING = ["sub-pub", "rfc-edit", ]
592592
GROUP_TYPES_LISTED_ACTIVE = ['wg', 'rg', 'ag', 'team', 'dir', 'review', 'area', 'program', ]
593593

594+
# Review team releated settings
595+
GROUP_REVIEW_MAX_ITEMS_TO_SHOW_IN_REVIEWER_LIST = 10
596+
GROUP_REVIEW_DAYS_TO_SHOW_IN_REVIEWER_LIST = 365
597+
594598
DATE_FORMAT = "Y-m-d"
595599
DATETIME_FORMAT = "Y-m-d H:i T"
596600

0 commit comments

Comments
 (0)