Skip to content

Commit 8e85a27

Browse files
committed
Replaced /liaison/managers/ with direct to static page on www.ietf.org
- Legacy-Id: 1638
1 parent 9b64a11 commit 8e85a27

5 files changed

Lines changed: 49 additions & 72 deletions

File tree

changelog

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ ietfdb (2.32)
77
* Make Django testing framework work again. From Pasi.
88

99
* Minor fixes to bugs found by the testing framework. From Pasi.
10+
11+
* Replaced /liaison/managers/ with redirect to static page
12+
on www.ietf.org. From Pasi.
1013

1114
-- Henrik Levkowetz <henrik@levkowetz.com>
1215

ietf/liaisons/models.py

Lines changed: 42 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -96,45 +96,50 @@ class Meta:
9696
class Admin:
9797
pass
9898

99-
class SDOs(models.Model):
100-
sdo_id = models.AutoField(primary_key=True)
101-
sdo_name = models.CharField(blank=True, maxlength=255)
102-
def __str__(self):
103-
return self.sdo_name
104-
def liaisonmanager(self):
105-
try:
106-
return self.liaisonmanagers_set.all()[0]
107-
except:
108-
return None
109-
class Meta:
110-
db_table = 'sdos'
111-
class Admin:
112-
pass
99+
# This table is not used by any code right now, and according to Glen,
100+
# probably not currently (Aug 2009) maintained by the secretariat.
101+
#class SDOs(models.Model):
102+
# sdo_id = models.AutoField(primary_key=True)
103+
# sdo_name = models.CharField(blank=True, maxlength=255)
104+
# def __str__(self):
105+
# return self.sdo_name
106+
# def liaisonmanager(self):
107+
# try:
108+
# return self.liaisonmanagers_set.all()[0]
109+
# except:
110+
# return None
111+
# class Meta:
112+
# db_table = 'sdos'
113+
# class Admin:
114+
# pass
113115

114-
class LiaisonManagers(models.Model):
115-
person = models.ForeignKey(PersonOrOrgInfo, db_column='person_or_org_tag', raw_id_admin=True)
116-
email_priority = models.IntegerField(null=True, blank=True, core=True)
117-
sdo = models.ForeignKey(SDOs, edit_inline=models.TABULAR, num_in_admin=1)
118-
def email(self):
119-
try:
120-
return self.person.emailaddress_set.get(priority=self.email_priority)
121-
except ObjectDoesNotExist:
122-
return None
123-
class Meta:
124-
db_table = 'liaison_managers'
116+
# This table is not used by any code right now, and according to Glen,
117+
# probably not currently (Aug 2009) maintained by the secretariat.
118+
#class LiaisonManagers(models.Model):
119+
# person = models.ForeignKey(PersonOrOrgInfo, db_column='person_or_org_tag', raw_id_admin=True)
120+
# email_priority = models.IntegerField(null=True, blank=True, core=True)
121+
# sdo = models.ForeignKey(SDOs, edit_inline=models.TABULAR, num_in_admin=1)
122+
# def email(self):
123+
# try:
124+
# return self.person.emailaddress_set.get(priority=self.email_priority)
125+
# except ObjectDoesNotExist:
126+
# return None
127+
# class Meta:
128+
# db_table = 'liaison_managers'
125129

126-
class LiaisonsInterim(models.Model):
127-
title = models.CharField(blank=True, maxlength=255)
128-
submitter_name = models.CharField(blank=True, maxlength=255)
129-
submitter_email = models.CharField(blank=True, maxlength=255)
130-
submitted_date = models.DateField(null=True, blank=True)
131-
from_id = models.IntegerField(null=True, blank=True)
132-
def __str__(self):
133-
return self.title
134-
class Meta:
135-
db_table = 'liaisons_interim'
136-
class Admin:
137-
pass
130+
# This table is not used by any code right now.
131+
#class LiaisonsInterim(models.Model):
132+
# title = models.CharField(blank=True, maxlength=255)
133+
# submitter_name = models.CharField(blank=True, maxlength=255)
134+
# submitter_email = models.CharField(blank=True, maxlength=255)
135+
# submitted_date = models.DateField(null=True, blank=True)
136+
# from_id = models.IntegerField(null=True, blank=True)
137+
# def __str__(self):
138+
# return self.title
139+
# class Meta:
140+
# db_table = 'liaisons_interim'
141+
# class Admin:
142+
# pass
138143

139144
class Uploads(models.Model):
140145
file_id = models.AutoField(primary_key=True)

ietf/liaisons/testurl.list

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
200 /liaison/458/ # non-ASCII title
66
200 /liaison/471/ # non-ASCII body and submitter name
77

8-
200 /liaison/managers/
8+
301 /liaison/managers/
9+
910
200 /liaison/help/to_ietf/
1011
200 /liaison/help/from_ietf/
1112
200 /liaison/help/fields/

ietf/liaisons/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright The IETF Trust 2007, All Rights Reserved
22

33
from django.conf.urls.defaults import patterns
4-
from ietf.liaisons.models import LiaisonDetail, LiaisonManagers
4+
from ietf.liaisons.models import LiaisonDetail
55

66
info_dict = {
77
'queryset': LiaisonDetail.objects.all().order_by("-submitted_date"),
@@ -11,12 +11,12 @@
1111
urlpatterns = patterns('django.views.generic.list_detail',
1212
(r'^$', 'object_list', info_dict),
1313
(r'^(?P<object_id>\d+)/$', 'object_detail', info_dict),
14-
(r'^managers/$', 'object_list', { 'queryset': LiaisonManagers.objects.all().select_related().order_by('sdos.sdo_name') }), #XXX order_by relies on select_related()
1514
)
1615

1716
urlpatterns += patterns('django.views.generic.simple',
1817
(r'^help/$', 'direct_to_template', {'template': 'liaisons/help.html'}),
1918
(r'^help/fields/$', 'direct_to_template', {'template': 'liaisons/field_help.html'}),
2019
(r'^help/from_ietf/$', 'direct_to_template', {'template': 'liaisons/guide_from_ietf.html'}),
2120
(r'^help/to_ietf/$', 'direct_to_template', {'template': 'liaisons/guide_to_ietf.html'}),
21+
(r'^managers/$', 'redirect_to', { 'url': 'http://www.ietf.org/liaison/managers.html' })
2222
)

ietf/templates/liaisons/liaisonmanagers_list.html

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)