Merged in ^/branch/proceedings/6.33.1.dev0 from rjsparks@nostrum.com and rcross@amsl.com. This provides new ietf meeting proceedings pages.

 - Legacy-Id: 12028

Author: levkowetz

ietf/doc/models.py

@@ -60,7 +60,7 @@ class DocumentInfo(models.Model):
     abstract = models.TextField(blank=True)
     rev = models.CharField(verbose_name="revision", max_length=16, blank=True)
     pages = models.IntegerField(blank=True, null=True)
-    order = models.IntegerField(default=1, blank=True)
+    order = models.IntegerField(default=1, blank=True) # This is probably obviated by SessionPresentaion.order
     intended_std_level = models.ForeignKey(IntendedStdLevelName, verbose_name="Intended standardization level", blank=True, null=True)
     std_level = models.ForeignKey(StdLevelName, verbose_name="Standardization level", blank=True, null=True)
     ad = models.ForeignKey(Person, verbose_name="area director", related_name='ad_%(class)s_set', blank=True, null=True)

ietf/meeting/factories.py

@@ -2,7 +2,6 @@
 import random
 import datetime
 
-from django.db.models import Max
 from django.core.files.base import ContentFile
 
 from ietf.meeting.models import Meeting, Session, Schedule, TimeSlot, SessionPresentation, FloorPlan
@@ -31,7 +30,8 @@ class Meta:
     def number(self,n):
         if self.type_id == 'ietf':
             if Meeting.objects.filter(type='ietf').exists():
-                return '%02d'%(int(Meeting.objects.filter(type='ietf').aggregate(Max('number'))['number__max'])+1)
+                so_far = max([int(x.number) for x in Meeting.objects.filter(type='ietf')])
+                return '%02d'%(so_far+1)
             else:
                 return '%02d'%(n+80)
         else:

ietf/meeting/migrations/0037_change_meta_options_on_sessionpresentation.py

@@ -0,0 +1,18 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('meeting', '0036_add_order_to_sessionpresentation'),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name='sessionpresentation',
+            options={'ordering': ('order',)},
+        ),
+    ]

ietf/meeting/models.py

@@ -963,6 +963,7 @@ class SessionPresentation(models.Model):
 
     class Meta:
         db_table = 'meeting_session_materials'
+        ordering = ('order',)
 
     def __unicode__(self):
         return u"%s -> %s-%s" % (self.session, self.document.name, self.rev)
@@ -1005,7 +1006,7 @@ def get_material(self, material_type, only_one):
             for d in l:
                 d.meeting_related = lambda: True
         else:
-            l = self.materials.filter(type=material_type).exclude(states__type=material_type, states__slug='deleted').order_by("order")
+            l = self.materials.filter(type=material_type).exclude(states__type=material_type, states__slug='deleted').order_by('sessionpresentation__order')
 
         if only_one:
             if l:

ietf/meeting/tests_js.py

@@ -7,10 +7,13 @@
 
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 from django.core.urlresolvers import reverse as urlreverse
+#from django.test.utils import override_settings
 
 import debug                            # pyflakes:ignore
 
+from ietf.doc.factories import DocumentFactory
 from ietf.group import colors
+from ietf.meeting.factories import SessionFactory
 from ietf.meeting.test_data import make_meeting_test_data
 from ietf.meeting.models import SchedTimeSessAssignment
 from ietf.utils.test_runner import set_coverage_checking
@@ -43,15 +46,23 @@ def condition_data():
 
 @skipIf(skip_selenium, skip_message)
 class ScheduleEditTests(StaticLiveServerTestCase):
-    def setUp(self):
+    @classmethod
+    def setUpClass(cls):
         set_coverage_checking(False)
-        condition_data()
+        super(ScheduleEditTests, cls).setUpClass()        
+
+    @classmethod
+    def tearDownClass(cls):
+        super(ScheduleEditTests, cls).tearDownClass()
+        set_coverage_checking(True)
+
+    def setUp(self):
         self.driver = webdriver.PhantomJS(port=0, service_log_path=settings.TEST_GHOSTDRIVER_LOG_PATH)
         self.driver.set_window_size(1024,768)
+        condition_data()
 
     def tearDown(self):
         self.driver.close()
-        set_coverage_checking(True)        
 
     def debugSnapshot(self,filename='debug_this.png'):
         self.driver.execute_script("document.body.bgColor = 'white';")
@@ -88,6 +99,57 @@ def testUnschedule(self):
         time.sleep(0.1) # The API that modifies the database runs async
         self.assertEqual(SchedTimeSessAssignment.objects.filter(session__meeting__number=42,session__group__acronym='mars',schedule__name='test-agenda').count(),0)
 
+@skipIf(skip_selenium, skip_message)
+class SlideReorderTests(StaticLiveServerTestCase):
+    @classmethod
+    def setUpClass(cls):
+        set_coverage_checking(False)
+        super(SlideReorderTests, cls).setUpClass()        
+
+    @classmethod
+    def tearDownClass(cls):
+        super(SlideReorderTests, cls).tearDownClass()
+        set_coverage_checking(True)
+
+    def setUp(self):
+        self.driver = webdriver.PhantomJS(port=0, service_log_path=settings.TEST_GHOSTDRIVER_LOG_PATH)
+        self.driver.set_window_size(1024,768)
+        self.session = SessionFactory(meeting__type_id='ietf')
+        self.session.sessionpresentation_set.create(document=DocumentFactory(type_id='slides',name='one'),order=1)
+        self.session.sessionpresentation_set.create(document=DocumentFactory(type_id='slides',name='two'),order=2)
+        self.session.sessionpresentation_set.create(document=DocumentFactory(type_id='slides',name='three'),order=3)
+
+    def tearDown(self):
+        self.driver.close()
+
+    def absreverse(self,*args,**kwargs):
+        return '%s%s'%(self.live_server_url,urlreverse(*args,**kwargs))
+
+    def secr_login(self):
+        url = '%s%s'%(self.live_server_url, urlreverse('django.contrib.auth.views.login'))
+        self.driver.get(url)
+        self.driver.find_element_by_name('username').send_keys('secretary')
+        self.driver.find_element_by_name('password').send_keys('secretary+password')
+        self.driver.find_element_by_xpath('//button[@type="submit"]').click()
+
+    #@override_settings(DEBUG=True)
+    def testReorderSlides(self):
+        return
+        url = self.absreverse('ietf.meeting.views.session_details',
+                  kwargs=dict(
+                      num=self.session.meeting.number,
+                      acronym = self.session.group.acronym,))
+        self.secr_login()
+        self.driver.get(url)        
+        #debug.show('unicode(self.driver.page_source)')
+        second = self.driver.find_element_by_css_selector('#slides tr:nth-child(2)')
+        third = self.driver.find_element_by_css_selector('#slides tr:nth-child(3)')
+        ActionChains(self.driver).drag_and_drop(second,third).perform()
+
+        time.sleep(0.1) # The API that modifies the database runs async
+        names=self.session.sessionpresentation_set.values_list('document__name',flat=True) 
+        self.assertEqual(list(names),[u'one',u'three',u'two'])
+
 # The following are useful debugging tools
 
 # If you add this to a LiveServerTestCase and run just this test, you can browse

ietf/meeting/tests_views.py

@@ -260,7 +260,6 @@ def test_proceedings(self):
         self.write_materials_files(meeting, session)
 
         url = urlreverse("ietf.meeting.views.proceedings", kwargs=dict(num=meeting.number))
-        login_testing_unauthorized(self,"secretary",url)
         r = self.client.get(url)
         self.assertEqual(r.status_code, 200)
 
@@ -1271,7 +1270,7 @@ def test_finalize_proceedings(self):
         self.assertEqual(meeting.proceedings_final,True)
         self.assertEqual(meeting.session_set.filter(group__acronym="mars").first().sessionpresentation_set.filter(document__type="draft").first().rev,'00')
 
-class BluesheetsTests(TestCase):
+class MaterialsTests(TestCase):
 
     def setUp(self):
         self.materials_dir = os.path.abspath(settings.TEST_MATERIALS_DIR)
@@ -1284,14 +1283,14 @@ def tearDown(self):
         settings.AGENDA_PATH = self.saved_agenda_path
         shutil.rmtree(self.materials_dir)
 
-    def test_upload_blusheets(self):
+    def test_upload_bluesheets(self):
         session = SessionFactory(meeting__type_id='ietf')
         url = urlreverse('ietf.meeting.views.upload_session_bluesheets',kwargs={'num':session.meeting.number,'session_id':session.id})
         login_testing_unauthorized(self,"secretary",url)
         r = self.client.get(url)
         self.assertEqual(r.status_code, 200)
         q = PyQuery(r.content)
-        self.assertFalse(q("div.alert"))
+        self.assertTrue('Upload' in unicode(q("title")))
         self.assertFalse(session.sessionpresentation_set.exists())
         test_file = StringIO('this is some text for a test')
         test_file.name = "not_really.pdf"
@@ -1302,7 +1301,7 @@ def test_upload_blusheets(self):
         r = self.client.get(url)
         self.assertEqual(r.status_code, 200)
         q = PyQuery(r.content)
-        self.assertTrue(q("div.alert"))
+        self.assertTrue('Revise' in unicode(q("title")))
         test_file = StringIO('this is some different text for a test')
         test_file.name = "also_not_really.pdf"
         r = self.client.post(url,dict(file=test_file))
@@ -1317,11 +1316,160 @@ def test_upload_bluesheets_interim(self):
         r = self.client.get(url)
         self.assertEqual(r.status_code, 200)
         q = PyQuery(r.content)
-        self.assertFalse(q("div.alert"))
+        self.assertTrue('Upload' in unicode(q("title")))
         self.assertFalse(session.sessionpresentation_set.exists())
         test_file = StringIO('this is some text for a test')
         test_file.name = "not_really.pdf"
         r = self.client.post(url,dict(file=test_file))
         self.assertEqual(r.status_code, 302)
         bs_doc = session.sessionpresentation_set.filter(document__type_id='bluesheets').first().document
         self.assertEqual(bs_doc.rev,'00')
+
+    def test_upload_minutes_agenda(self):
+        for doctype in ('minutes','agenda'):
+            session = SessionFactory(meeting__type_id='ietf')
+            if doctype == 'minutes':
+                url = urlreverse('ietf.meeting.views.upload_session_minutes',kwargs={'num':session.meeting.number,'session_id':session.id})
+            else:
+                url = urlreverse('ietf.meeting.views.upload_session_agenda',kwargs={'num':session.meeting.number,'session_id':session.id})
+            self.client.logout()
+            login_testing_unauthorized(self,"secretary",url)
+            r = self.client.get(url)
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue('Upload' in unicode(q("Title")))
+            self.assertFalse(session.sessionpresentation_set.exists())
+            self.assertFalse(q('form input[type="checkbox"]'))
+    
+            session2 = SessionFactory(meeting=session.meeting,group=session.group)
+            r = self.client.get(url)
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue(q('form input[type="checkbox"]'))
+    
+            test_file = StringIO('this is some text for a test')
+            test_file.name = "not_really.json"
+            r = self.client.post(url,dict(file=test_file))
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue(q('form .has-error'))
+    
+            test_file = StringIO('this is some text for a test'*1510000)
+            test_file.name = "not_really.pdf"
+            r = self.client.post(url,dict(file=test_file))
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue(q('form .has-error'))
+    
+            test_file = StringIO('this is some text for a test')
+            test_file.name = "not_really.txt"
+            r = self.client.post(url,dict(file=test_file,apply_to_all=False))
+            self.assertEqual(r.status_code, 302)
+            doc = session.sessionpresentation_set.filter(document__type_id=doctype).first().document
+            self.assertEqual(doc.rev,'00')
+            self.assertFalse(session2.sessionpresentation_set.filter(document__type_id=doctype))
+    
+            r = self.client.get(url)
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue('Revise' in unicode(q("Title")))
+            test_file = StringIO('this is some different text for a test')
+            test_file.name = "also_not_really.txt"
+            r = self.client.post(url,dict(file=test_file,apply_to_all=True))
+            self.assertEqual(r.status_code, 302)
+            doc = Document.objects.get(pk=doc.pk)
+            self.assertEqual(doc.rev,'01')
+            self.assertTrue(session2.sessionpresentation_set.filter(document__type_id=doctype))
+
+    def test_upload_minutes_agenda_interim(self):
+        session=SessionFactory(meeting__type_id='interim')
+        for doctype in ('minutes','agenda'):
+            if doctype=='minutes':
+                url = urlreverse('ietf.meeting.views.upload_session_minutes',kwargs={'num':session.meeting.number,'session_id':session.id})
+            else:
+                url = urlreverse('ietf.meeting.views.upload_session_agenda',kwargs={'num':session.meeting.number,'session_id':session.id})
+            self.client.logout()
+            login_testing_unauthorized(self,"secretary",url)
+            r = self.client.get(url)
+            self.assertEqual(r.status_code, 200)
+            q = PyQuery(r.content)
+            self.assertTrue('Upload' in unicode(q("title")))
+            self.assertFalse(session.sessionpresentation_set.filter(document__type_id=doctype))
+            test_file = StringIO('this is some text for a test')
+            test_file.name = "not_really.txt"
+            r = self.client.post(url,dict(file=test_file))
+            self.assertEqual(r.status_code, 302)
+            doc = session.sessionpresentation_set.filter(document__type_id=doctype).first().document
+            self.assertEqual(doc.rev,'00')
+
+    def test_upload_slides(self):
+
+        session1 = SessionFactory(meeting__type_id='ietf')
+        session2 = SessionFactory(meeting=session1.meeting,group=session1.group)
+        url = urlreverse('ietf.meeting.views.upload_session_slides',kwargs={'num':session1.meeting.number,'session_id':session1.id})
+        login_testing_unauthorized(self,"secretary",url)
+        r = self.client.get(url)
+        self.assertEqual(r.status_code, 200)
+        q = PyQuery(r.content)
+        self.assertTrue('Upload' in unicode(q("title")))
+        self.assertFalse(session1.sessionpresentation_set.filter(document__type_id='slides'))
+        test_file = StringIO('this is not really a slide')
+        test_file.name = 'not_really.txt'
+        r = self.client.post(url,dict(file=test_file,title='a test slide file',apply_to_all=True))
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(session1.sessionpresentation_set.count(),1) 
+        self.assertEqual(session2.sessionpresentation_set.count(),1) 
+        sp = session2.sessionpresentation_set.first()
+        self.assertEqual(sp.document.name, 'slides-%s-%s-a-test-slide-file' % (session1.meeting.number,session1.group.acronym ) )
+        self.assertEqual(sp.order,1)
+
+        url = urlreverse('ietf.meeting.views.upload_session_slides',kwargs={'num':session2.meeting.number,'session_id':session2.id})
+        test_file = StringIO('some other thing still not slidelike')
+        test_file.name = 'also_not_really.txt'
+        r = self.client.post(url,dict(file=test_file,title='a different slide file',apply_to_all=False))
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(session1.sessionpresentation_set.count(),1)
+        self.assertEqual(session2.sessionpresentation_set.count(),2)
+        sp = session2.sessionpresentation_set.get(document__name__endswith='-a-different-slide-file')
+        self.assertEqual(sp.order,2)
+        self.assertEqual(sp.rev,u'00')
+        self.assertEqual(sp.document.rev,u'00')
+
+        url = urlreverse('ietf.meeting.views.upload_session_slides',kwargs={'num':session2.meeting.number,'session_id':session2.id,'name':session2.sessionpresentation_set.get(order=2).document.name})
+        r = self.client.get(url)
+        self.assertTrue(r.status_code, 200)
+        q = PyQuery(r.content)
+        self.assertTrue('Revise' in unicode(q("title")))
+        test_file = StringIO('new content for the second slide deck')
+        test_file.name = 'doesnotmatter.txt'
+        r = self.client.post(url,dict(file=test_file,title='rename the presentation',apply_to_all=False))
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(session1.sessionpresentation_set.count(),1)
+        self.assertEqual(session2.sessionpresentation_set.count(),2)
+        sp = session2.sessionpresentation_set.get(order=2)
+        self.assertEqual(sp.rev,u'01')
+        self.assertEqual(sp.document.rev,u'01')
+ 
+    def test_remove_sessionpresentation(self):
+        session = SessionFactory(meeting__type_id='ietf')
+        doc = DocumentFactory(type_id='slides')
+        session.sessionpresentation_set.create(document=doc)
+
+        url = urlreverse('ietf.meeting.views.remove_sessionpresentation',kwargs={'num':session.meeting.number,'session_id':session.id,'name':'no-such-doc'})
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 404)
+
+        url = urlreverse('ietf.meeting.views.remove_sessionpresentation',kwargs={'num':session.meeting.number,'session_id':0,'name':doc.name})
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 404)
+
+        url = urlreverse('ietf.meeting.views.remove_sessionpresentation',kwargs={'num':session.meeting.number,'session_id':session.id,'name':doc.name})
+        login_testing_unauthorized(self,"secretary",url)
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+
+        self.assertEqual(1,session.sessionpresentation_set.count())
+        response = self.client.post(url,{'remove_session':''})
+        self.assertEqual(response.status_code, 302)
+        self.assertEqual(0,session.sessionpresentation_set.count())
+        self.assertEqual(2,doc.docevent_set.count())

ietf/meeting/urls.py

@@ -11,6 +11,11 @@
     url(r'^session/(?P<acronym>[-a-z0-9]+)/?$',  views.session_details),
     url(r'^session/(?P<session_id>\d+)/drafts$',  views.add_session_drafts),
     url(r'^session/(?P<session_id>\d+)/bluesheets$', views.upload_session_bluesheets),
+    url(r'^session/(?P<session_id>\d+)/minutes$', views.upload_session_minutes),
+    url(r'^session/(?P<session_id>\d+)/agenda$', views.upload_session_agenda),
+    url(r'^session/(?P<session_id>\d+)/slides(?:/%(name)s)?$' % settings.URL_REGEXPS, views.upload_session_slides),
+    url(r'^session/(?P<session_id>\d+)/slides/%(name)s/order$' % settings.URL_REGEXPS, views.set_slide_order),
+    url(r'^session/(?P<session_id>\d+)/doc/%(name)s/remove$' % settings.URL_REGEXPS, views.remove_sessionpresentation),
 ]