Skip to content

Commit 8b5ce04

Browse files
committed
IESG discuss page: better switching between all/by me/for me
- Legacy-Id: 1945
1 parent 53baa05 commit 8b5ce04

1 file changed

Lines changed: 28 additions & 26 deletions

File tree

ietf/templates/iesg/discusses.html

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% extends "idrfc/base.html" %}
22
{% comment %}
3-
Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies).
3+
Copyright (C) 2009-2010 Nokia Corporation and/or its subsidiary(-ies).
44
All rights reserved. Contact: Pasi Eronen <pasi.eronen@nokia.com>
55

66
Redistribution and use in source and binary forms, with or without
@@ -48,21 +48,18 @@
4848
<h1 style="margin-top:0;">IESG Discuss Positions</h1>
4949

5050
{% if user|in_group:"Area_Director" %}
51-
<div id="discuss_show1" style="display:block;">
52-
<a href="javascript:show_only_mine()">Show only my discusses</a>
51+
<div style="padding:4px 0;">
52+
Show: <input type="radio" name="discuss_show" checked="checked" value="all" id="discusses_all" onclick="radio_changed();"/>All
53+
<input type="radio" name="discuss_show" value="byme" id="discusses_byme" onclick="radio_changed();"/>By me
54+
<input type="radio" name="discuss_show" value="forme" id="discusses_forme" onclick="radio_changed();"/>For me
5355
</div>
54-
<div id="discuss_show2" style="display:none;">
55-
<a href="javascript:show_all()">Show all discusses (currently showing only mine)</a>
56-
</div>
57-
<div style="padding-top:4px;"></div>
5856
{% endif %}
5957

6058
<div class="search_results">
6159
<table id="discuss_table">
6260
<tr><th class="doc">Document</th><th class="status" colspan="2">Status</th><th class="ad">Area Director</th><th>Discusses</th></tr>
6361
{% for doc in docs %}
64-
<tr {% if user|in_group:"Area_Director" %}{% if doc|my_position:user|equal:"Discuss" %}
65-
class="discuss_my" {% else %} class="discuss_not_my" {% endif %}{% endif %}>
62+
<tr{% if user|in_group:"Area_Director" %} class="{% if doc|my_position:user|equal:"Discuss" %}discuss_byme{% else %}discuss_notbyme{% endif %} {% ifequal user.get_profile.person|lower doc.ad_name|lower %}discuss_forme{%else%}discuss_notforme{%endifequal%}"{% endif %}>
6663
<td class="doc">
6764
{% if doc.is_rfc_wrapper %}
6865
<a href="/doc/rfc{{doc.rfc_number}}/">RFC {{doc.rfc_number}}</a>
@@ -86,23 +83,28 @@ <h1 style="margin-top:0;">IESG Discuss Positions</h1>
8683
{% endblock %}
8784

8885
{% block scripts %}
89-
function show_only_mine() {
90-
document.getElementById("discuss_show2").style.display = 'block';
91-
document.getElementById("discuss_show1").style.display = 'none';
92-
93-
var els = YAHOO.util.Dom.getElementsByClassName("discuss_not_my","tr");
94-
var i;
95-
for (i =0; i < els.length; i++) {
96-
YAHOO.util.Dom.addClass(els[i], "discuss_hidden");
97-
}
98-
}
99-
function show_all() {
100-
document.getElementById("discuss_show1").style.display = 'block';
101-
document.getElementById("discuss_show2").style.display = 'none';
102-
var els = YAHOO.util.Dom.getElementsByClassName("discuss_not_my","tr");
103-
var i;
104-
for (i =0; i < els.length; i++) {
105-
YAHOO.util.Dom.removeClass(els[i], "discuss_hidden");
86+
{% if user|in_group:"Area_Director" %}
87+
function radio_changed() {
88+
var els1 = YAHOO.util.Dom.getElementsByClassName("discuss_notbyme","tr");
89+
YAHOO.util.Dom.removeClass(els1, "discuss_hidden");
90+
var els2 = YAHOO.util.Dom.getElementsByClassName("discuss_notforme","tr");
91+
YAHOO.util.Dom.removeClass(els2, "discuss_hidden");
92+
if (document.getElementById("discusses_all").checked) {
93+
// done
94+
} else if (document.getElementById("discusses_byme").checked) {
95+
YAHOO.util.Dom.addClass(els1, "discuss_hidden");
96+
} else if (document.getElementById("discusses_forme").checked) {
97+
els = YAHOO.util.Dom.getElementsByClassName("discuss_notforme","tr");
98+
YAHOO.util.Dom.addClass(els2, "discuss_hidden");
99+
}
106100
}
101+
var url = location.href.split('#');
102+
if (url[1] == 'byme') {
103+
document.getElementById("discusses_byme").checked = true;
104+
radio_changed();
105+
} else if (url[1] == 'forme') {
106+
document.getElementById("discusses_forme").checked = true;
107+
radio_changed();
107108
}
109+
{% endif %}{# user in_group #}
108110
{% endblock scripts %}

0 commit comments

Comments
 (0)