Skip to content

Commit 89ef806

Browse files
committed
Merged in [15701] from kivinen@iki.fi:
Changed format of the reviewer statistics in lists. Fixes ietf-tools#2131. - Legacy-Id: 15735 Note: SVN reference [15701] has been migrated to Git commit 56acd00
2 parents 98015a6 + 56acd00 commit 89ef806

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

ietf/doc/tests_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ def test_assign_reviewer(self):
355355
self.assertIn("unavailable indefinitely", reviewer_label)
356356
self.assertIn("skip next 1", reviewer_label)
357357
self.assertIn("#1", reviewer_label)
358-
self.assertIn("no response 0/1", reviewer_label)
358+
self.assertIn("1 fully completed", reviewer_label)
359359

360360
# assign
361361
empty_outbox()

ietf/review/utils.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -832,8 +832,15 @@ def format_period(p):
832832
stats.append("currently {count} open, {pages} pages".format(count=currently_open, pages=pages))
833833
could_have_completed = [d for d in req_data if d.state in ["part-completed", "completed", "no-response"]]
834834
if could_have_completed:
835-
no_response = sum(1 for d in could_have_completed if d.state == "no-response")
836-
stats.append("no response {}/{}".format(no_response, len(could_have_completed)))
835+
no_response = len([d for d in req_data if d.state == 'no-response'])
836+
if no_response:
837+
stats.append("%s no response" % no_response)
838+
part_completed = len([d for d in req_data if d.state == 'part-completed'])
839+
if part_completed:
840+
stats.append("%s partially complete" % part_completed)
841+
completed = len([d for d in req_data if d.state == 'completed'])
842+
if completed:
843+
stats.append("%s fully completed" % completed)
837844

838845
if stats:
839846
explanations.append(", ".join(stats))

0 commit comments

Comments
 (0)