Skip to content

Commit 892c7d4

Browse files
committed
Reuse already fetched page instead of refetching it in nomcom test
- Legacy-Id: 6922
1 parent b302ffa commit 892c7d4

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

ietf/nomcom/tests.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class NomcomViewsTest(TestCase):
4444
def check_url_status(self, url, status):
4545
response = self.client.get(url)
4646
self.assertEqual(response.status_code, status)
47+
return response
4748

4849
def setUp(self):
4950
nomcom_test_data()
@@ -73,19 +74,19 @@ def access_member_url(self, url):
7374
self.check_url_status(url, 200)
7475
self.client.logout()
7576
login_testing_unauthorized(self, MEMBER_USER, url)
76-
self.check_url_status(url, 200)
77+
return self.check_url_status(url, 200)
7778

7879
def access_chair_url(self, url):
7980
login_testing_unauthorized(self, COMMUNITY_USER, url)
8081
login_testing_unauthorized(self, MEMBER_USER, url)
8182
login_testing_unauthorized(self, CHAIR_USER, url)
82-
self.check_url_status(url, 200)
83+
return self.check_url_status(url, 200)
8384

8485
def access_secretariat_url(self, url):
8586
login_testing_unauthorized(self, COMMUNITY_USER, url)
8687
login_testing_unauthorized(self, CHAIR_USER, url)
8788
login_testing_unauthorized(self, SECRETARIAT_USER, url)
88-
self.check_url_status(url, 200)
89+
return self.check_url_status(url, 200)
8990

9091
def test_private_index_view(self):
9192
"""Verify private home view"""
@@ -343,9 +344,7 @@ def test_edit_chair_view(self):
343344
self.client.logout()
344345

345346
def test_edit_nomcom_view(self):
346-
self.access_chair_url(self.edit_nomcom_url)
347-
348-
r = self.client.get(self.edit_nomcom_url)
347+
r = self.access_chair_url(self.edit_nomcom_url)
349348
q = PyQuery(r.content)
350349

351350
f = open(self.cert_file.name)

0 commit comments

Comments
 (0)