Skip to content

Commit 873af38

Browse files
committed
Summary: Return a friendlier error in case the room view is accessed
before the meeting is properly defined, this also fixes a problem with the crawler - Legacy-Id: 10124
1 parent 009b5ad commit 873af38

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

ietf/meeting/views.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -709,13 +709,13 @@ def room_view(request, num=None):
709709
meeting = get_meeting(num)
710710

711711
rooms = meeting.room_set.order_by('functional_name','name')
712-
if rooms.count() == 0:
713-
raise Http404
712+
if not rooms:
713+
return HttpResponse("No rooms defined yet")
714714

715715
scheduledsessions = meeting.agenda.scheduledsession_set.all()
716716
unavailable = meeting.timeslot_set.filter(type__slug='unavail')
717-
if (unavailable.count() + scheduledsessions.count()) == 0 :
718-
raise Http404
717+
if not (unavailable or scheduledsessions):
718+
return HttpResponse("No sessions/timeslots available yet")
719719

720720
earliest = None
721721
latest = None

0 commit comments

Comments
 (0)