Skip to content

Commit 85cfe0e

Browse files
committed
Show leadership when and where mail was sent at the time it is sent. Commit ready for merge.
- Legacy-Id: 9608
1 parent 374e77b commit 85cfe0e

3 files changed

Lines changed: 25 additions & 2 deletions

File tree

ietf/iesg/tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,8 @@ def test_reschedule(self):
435435
r = self.client.get(url)
436436
self.assertEqual(r.status_code, 200)
437437
d_header_pos = r.content.find("IESG telechat %s" % d.isoformat())
438-
draft_pos = r.content.find(draft.name)
439-
self.assertTrue(d_header_pos < draft_pos)
438+
draft_pos = r.content[d_header_pos:].find(draft.name)
439+
self.assertTrue(draft_pos>0)
440440

441441
self.assertTrue(draft.latest_event(TelechatDocEvent, "scheduled_for_telechat"))
442442
self.assertEqual(draft.latest_event(TelechatDocEvent, "scheduled_for_telechat").telechat_date, d)

ietf/utils/mail.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import copy
2222
import textwrap
2323
import traceback
24+
import datetime
2425

2526
# Testing mode:
2627
# import ietf.utils.mail
@@ -228,6 +229,19 @@ def condition_message(to, frm, subject, msg, cc, extra):
228229
if v:
229230
msg[k] = v
230231

232+
def show_that_mail_was_sent(request,leadline,msg,bcc):
233+
if request and request.user:
234+
from ietf.ietfauth.utils import has_role
235+
if has_role(request.user,['Area Director','Secretariat','IANA','RFC Editor','ISE','IAD','IRTF Chair','WG Chair','RG Chair','WG Secretary','RG Secretary']):
236+
info = "%s at %s %s\n" % (leadline,datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S"),settings.TIME_ZONE)
237+
info += "Subject: %s\n" % msg.get('Subject','[no subject]')
238+
info += "To: %s\n" % msg.get('To','[no to]')
239+
if msg.get('Cc'):
240+
info += "Cc: %s\n" % msg.get('Cc')
241+
if bcc:
242+
info += "Bcc: %s\n" % bcc
243+
messages.info(request,info,extra_tags='preformatted',fail_silently=True)
244+
231245
def send_mail_mime(request, to, frm, subject, msg, cc=None, extra=None, toUser=False, bcc=None):
232246
"""Send MIME message with content already filled in."""
233247

@@ -238,13 +252,18 @@ def send_mail_mime(request, to, frm, subject, msg, cc=None, extra=None, toUser=F
238252
# and EMAIL_PORT=2025 in settings_local.py
239253
debugging = getattr(settings, "USING_DEBUG_EMAIL_SERVER", False) and settings.EMAIL_HOST == 'localhost' and settings.EMAIL_PORT == 2025
240254

255+
if settings.SERVER_MODE == 'development':
256+
show_that_mail_was_sent(request,'In production, email would have been sent',msg,bcc)
257+
241258
if test_mode or debugging or settings.SERVER_MODE == 'production':
242259
try:
243260
send_smtp(msg,bcc)
244261
except smtplib.SMTPException as e:
245262
log_smtp_exception(e)
246263
build_warning_message(request, e)
247264
send_error_email(e)
265+
266+
show_that_mail_was_sent(request,'Email was sent',msg,bcc)
248267

249268
elif settings.SERVER_MODE == 'test':
250269
if toUser:

static/css/ietf.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,10 @@ pre {
178178
font-size: 14px;
179179
}
180180

181+
.preformatted {
182+
white-space: pre;
183+
}
184+
181185
/* Make ampersands pretty */
182186
/* This sets ampersand in a different font than the rest of the text. Fancy, but it's
183187
really better to select a pretty font in the first place. Additionally, _which_ 'pretty'

0 commit comments

Comments
 (0)