Skip to content

Commit 85458ab

Browse files
committed
Change when the consensus field is displayed and who can edit it for IETF stream documents. Fixes bug ietf-tools#1380. Commit ready for merge.
- Legacy-Id: 7590
1 parent 7fb3e91 commit 85458ab

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,18 @@ def document_main(request, name, rev=None):
265265

266266
can_edit_stream_info = is_authorized_in_doc_stream(request.user, doc)
267267
can_edit_shepherd_writeup = can_edit_stream_info or user_is_person(request.user, doc.shepherd) or has_role(request.user, ["Area Director"])
268+
can_edit_consensus = False
268269

269270
consensus = None
270-
if doc.stream_id in ("ietf", "irtf", "iab"):
271+
if doc.stream_id == "ietf" and iesg_state:
272+
show_in_states = set(IESG_BALLOT_ACTIVE_STATES)
273+
show_in_states.update(('approved','ann','rfcqueue','pub'))
274+
if iesg_state.slug in show_in_states:
275+
can_edit_consensus = can_edit
276+
e = doc.latest_event(ConsensusDocEvent, type="changed_consensus")
277+
consensus = nice_consensus(e and e.consensus)
278+
elif doc.stream_id in ("irtf", "iab"):
279+
can_edit_consensus = can_edit or can_edit_stream_info
271280
e = doc.latest_event(ConsensusDocEvent, type="changed_consensus")
272281
consensus = nice_consensus(e and e.consensus)
273282

@@ -342,6 +351,7 @@ def document_main(request, name, rev=None):
342351
can_edit_stream_info=can_edit_stream_info,
343352
can_edit_shepherd_writeup=can_edit_shepherd_writeup,
344353
can_edit_iana_state=can_edit_iana_state,
354+
can_edit_consensus=can_edit_consensus,
345355

346356
rfc_number=rfc_number,
347357
draft_name=draft_name,

ietf/templates/doc/document_draft.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
<tr>
122122
<td>Consensus:</td>
123123
<td>
124-
<a title="Whether the document is the result of a community consensus process as defined in RFC 5741" {% if can_edit or can_edit_stream_info %}class="editlink" href="{% url "doc_edit_consensus" name=doc.name %}"{% endif %}>
124+
<a title="Whether the document is the result of a community consensus process as defined in RFC 5741" {% if can_edit_consensus %}class="editlink" href="{% url "doc_edit_consensus" name=doc.name %}"{% endif %}>
125125
{{ consensus }}
126126
</a>
127127
</td>

0 commit comments

Comments
 (0)