Skip to content

Commit 8436078

Browse files
committed
Made settings.URL_REGEXPS.name non-greedy. Added a test to exercise the bug at ietf-tools#2429. Fixes ietf-tools#2429. Commit ready for merge.
- Legacy-Id: 15110
1 parent 2230c5c commit 8436078

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

ietf/doc/tests.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,9 @@ def test_document_draft(self):
531531
self.assertEqual(len(q('.rfcmarkup span.h1')), 2)
532532
self.assertEqual(len(q('.rfcmarkup a[href]')), 30)
533533

534+
r = self.client.get(urlreverse("ietf.doc.views_doc.document_html", kwargs=dict(name=draft.name, rev=draft.rev)))
535+
self.assertEqual(r.status_code, 200)
536+
534537
# expired draft
535538
draft.set_state(State.objects.get(type="draft", slug="expired"))
536539

ietf/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ def skip_unreadable_post(record):
550550
"acronym": r"(?P<acronym>[-a-z0-9]+)",
551551
"charter": r"(?P<name>charter-[-a-z0-9]+)",
552552
"date": r"(?P<date>\d{4}-\d{2}-\d{2})",
553-
"name": r"(?P<name>[A-Za-z0-9._+-]+)",
553+
"name": r"(?P<name>[A-Za-z0-9._+-]+?)",
554554
"document": r"(?P<document>[a-z][-a-z0-9]+)", # regular document names
555555
"rev": r"(?P<rev>[0-9]{1,2}(-[0-9]{2})?)",
556556
"owner": r"(?P<owner>[-A-Za-z0-9\'+._]+@[A-Za-z0-9-._]+)",

0 commit comments

Comments
 (0)