Skip to content

Commit 805d1f4

Browse files
committed
Use BOF consistently.
- Legacy-Id: 19212
1 parent 885fe35 commit 805d1f4

23 files changed

Lines changed: 74 additions & 70 deletions

ietf/doc/migrations/0042_bofreq_states.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ def forward(apps, schema_editor):
88
StateType = apps.get_model('doc', 'StateType')
99
State = apps.get_model('doc', 'State')
1010

11-
StateType.objects.create(slug='bofreq', label='Bof Request State')
12-
proposed = State.objects.create(type_id='bofreq', slug='proposed', name='Proposed', used=True, desc='The bof request is proposed', order=0)
13-
approved = State.objects.create(type_id='bofreq', slug='approved', name='Approved', used=True, desc='The bof request is approved', order=1)
14-
declined = State.objects.create(type_id='bofreq', slug='declined', name='Declined', used=True, desc='The bof request is declined', order=2)
15-
replaced = State.objects.create(type_id='bofreq', slug='replaced', name='Replaced', used=True, desc='The bof request is proposed', order=3)
16-
abandoned = State.objects.create(type_id='bofreq', slug='abandoned', name='Abandoned', used=True, desc='The bof request is abandoned', order=4)
11+
StateType.objects.create(slug='bofreq', label='BOF Request State')
12+
proposed = State.objects.create(type_id='bofreq', slug='proposed', name='Proposed', used=True, desc='The BOF request is proposed', order=0)
13+
approved = State.objects.create(type_id='bofreq', slug='approved', name='Approved', used=True, desc='The BOF request is approved', order=1)
14+
declined = State.objects.create(type_id='bofreq', slug='declined', name='Declined', used=True, desc='The BOF request is declined', order=2)
15+
replaced = State.objects.create(type_id='bofreq', slug='replaced', name='Replaced', used=True, desc='The BOF request is proposed', order=3)
16+
abandoned = State.objects.create(type_id='bofreq', slug='abandoned', name='Abandoned', used=True, desc='The BOF request is abandoned', order=4)
1717

1818
proposed.next_states.set([approved,declined,replaced,abandoned])
1919

ietf/doc/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,9 +1349,9 @@ class EditedAuthorsDocEvent(DocEvent):
13491349
basis = models.CharField(help_text="What is the source or reasoning for the changes to the author list",max_length=255)
13501350

13511351
class BofreqEditorDocEvent(DocEvent):
1352-
""" Capture the proponents of a Bof Request."""
1352+
""" Capture the proponents of a BOF Request."""
13531353
editors = models.ManyToManyField('person.Person', blank=True)
13541354

13551355
class BofreqResponsibleDocEvent(DocEvent):
1356-
""" Capture the responsible leadership (IAB and IESG members) for a BoF Request """
1356+
""" Capture the responsible leadership (IAB and IESG members) for a BOF Request """
13571357
responsible = models.ManyToManyField('person.Person', blank=True)

ietf/doc/tests_bofreq.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def write_bofreq_file(self, bofreq):
4646
def test_show_bof_requests(self):
4747
url = urlreverse('ietf.doc.views_bofreq.bof_requests')
4848
r = self.client.get(url)
49-
self.assertContains(r, 'There are currently no BoF Requests', status_code=200)
49+
self.assertContains(r, 'There are currently no BOF Requests', status_code=200)
5050
states = State.objects.filter(type_id='bofreq')
5151
self.assertTrue(states.count()>0)
5252
reqs = BofreqFactory.create_batch(states.count())

ietf/doc/tests_charter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ def test_abandon_bof(self):
275275
login_testing_unauthorized(self, "secretary", url)
276276
response=self.client.get(url)
277277
self.assertEqual(response.status_code,200)
278-
response = self.client.post(url,{'comment':'Testing Abandoning a Bof Charter'})
278+
response = self.client.post(url,{'comment':'Testing Abandoning a BOF Charter'})
279279
self.assertEqual(response.status_code,302)
280280
charter = Document.objects.get(pk=charter.pk)
281281
self.assertEqual(charter.group.state_id,'abandon')

ietf/doc/views_bofreq.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def clean_bofreq_content(self):
4646
content = self.cleaned_data["bofreq_content"].replace("\r", "")
4747
default_content = render_to_string('doc/bofreq/bofreq_template.md',{})
4848
if content==default_content:
49-
raise forms.ValidationError('The example content may not be saved. Edit it as instructed to document this BoF request.')
49+
raise forms.ValidationError('The example content may not be saved. Edit it as instructed to document this BOF request.')
5050
try:
5151
_ = markdown.markdown(content, extensions=['extra'])
5252
except Exception as e:
@@ -126,7 +126,7 @@ def clean_title(self):
126126
if name == 'bofreq-':
127127
raise forms.ValidationError('The filename derived from this title is empty. Please include a few descriptive words using ascii or numeric characters')
128128
if Document.objects.filter(name=name).exists():
129-
raise forms.ValidationError('This title produces a filename already used by an existing BoF request')
129+
raise forms.ValidationError('This title produces a filename already used by an existing BOF request')
130130
return title
131131

132132
@login_required

ietf/group/forms.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,11 @@ def clean_acronym(self):
188188

189189
if existing and existing.type_id == self.group_type:
190190
if existing.state_id == "bof":
191-
#insert_confirm_field(label="Turn BoF %s into proposed %s and start chartering it" % (existing.acronym, existing.type.name), initial=True)
191+
#insert_confirm_field(label="Turn BOF %s into proposed %s and start chartering it" % (existing.acronym, existing.type.name), initial=True)
192192
if confirmed:
193193
return acronym
194194
else:
195-
raise forms.ValidationError("Warning: Acronym used for an existing BoF (%s)." % existing.acronym)
195+
raise forms.ValidationError("Warning: Acronym used for an existing BOF (%s)." % existing.acronym)
196196
else:
197197
#insert_confirm_field(label="Set state of %s %s to proposed and start chartering it" % (existing.acronym, existing.type.name), initial=False)
198198
if confirmed:
@@ -265,7 +265,7 @@ def clean(self):
265265
state = cleaned_data.get('state', None)
266266
parent = cleaned_data.get('parent', None)
267267
if state and (state.slug in ['bof', ] and 'parent' in self.fields and not parent):
268-
raise forms.ValidationError("You requested the creation of a BoF, but specified no parent area. A parent is required when creating a bof.")
268+
raise forms.ValidationError("You requested the creation of a BOF, but specified no parent area. A parent is required when creating a bof.")
269269
return cleaned_data
270270

271271

ietf/group/tests_info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ def test_create_based_on_existing_bof(self):
561561
q = PyQuery(r.content)
562562
self.assertTrue(len(q('form .has-error')) > 0)
563563

564-
# try elevating BoF to WG
564+
# try elevating BOF to WG
565565
group.state_id = "bof"
566566
group.save()
567567

ietf/ipr/tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,8 @@ def test_search(self):
180180

181181
# find by patent info
182182
r = self.client.get(url + "?submit=patent&patent=%s" % ipr.patent_info)
183+
debug.show('ipr.patent_info')
184+
debug.show('r.content')
183185
self.assertContains(r, ipr.title)
184186

185187
r = self.client.get(url + "?submit=patent&patent=US12345")

ietf/meeting/management/commands/create_dummy_meeting.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ def handle(self, *args, **options):
366366
attendees=100,
367367
agenda_note="",
368368
requested_duration=datetime.timedelta(seconds=7200), # 2:00:00
369-
comments="""Must not conflict with Transport Area BoFs. """, # this is implicit
369+
comments="""Must not conflict with Transport Area BOFs. """, # this is implicit
370370
remote_instructions="",
371371
)
372372
## session for tsvwg ##
@@ -377,7 +377,7 @@ def handle(self, *args, **options):
377377
attendees=100,
378378
agenda_note="",
379379
requested_duration=datetime.timedelta(seconds=7200), # 2:00:00
380-
comments="""Must not conflict with Transport Area BoFs. """, # this is implicit
380+
comments="""Must not conflict with Transport Area BOFs. """, # this is implicit
381381
remote_instructions="",
382382
)
383383
c = Constraint.objects.create(meeting=m, source=s.group, name_id='conflict', target_id=1665, ) # intarea
@@ -440,7 +440,7 @@ def handle(self, *args, **options):
440440
attendees=80,
441441
agenda_note="Joint with ARTAREA",
442442
requested_duration=datetime.timedelta(seconds=7200), # 2:00:00
443-
comments=""" and avoid the same kind of conflicts with other area meetings and any Bofs and potential new ART WGs.""", # this is implicit
443+
comments=""" and avoid the same kind of conflicts with other area meetings and any BOFs and potential new ART WGs.""", # this is implicit
444444
remote_instructions="",
445445
)
446446
s.joint_with_groups.set(Group.objects.filter(acronym='artarea'))
@@ -2598,7 +2598,7 @@ def handle(self, *args, **options):
25982598
attendees=50,
25992599
agenda_note="",
26002600
requested_duration=datetime.timedelta(seconds=5400), # 1:30:00
2601-
comments="""Please avoid collision with any Sec and IoT-related BoFs.""",
2601+
comments="""Please avoid collision with any Sec and IoT-related BOFs.""",
26022602
remote_instructions="",
26032603
)
26042604
c = Constraint.objects.create(meeting=m, source=s.group, name_id='conflict', target_id=1187, ) # saag

ietf/meeting/management/commands/generate_schedule.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -705,24 +705,24 @@ def _calculate_cost_business_logic(self, overlapping_sessions):
705705
for other in overlapping_sessions:
706706
if not other:
707707
continue
708-
# BoFs cannot conflict with PRGs
708+
# BOFs cannot conflict with PRGs
709709
if self.is_bof and other.is_prg:
710-
violations.append('{}: BoF overlaps with PRG: {}'
710+
violations.append('{}: BOF overlaps with PRG: {}'
711711
.format(self.group, other.group))
712712
cost += self.business_constraint_costs['bof_overlapping_prg']
713-
# BoFs cannot conflict with any other BoFs
713+
# BOFs cannot conflict with any other BOFs
714714
if self.is_bof and other.is_bof:
715-
violations.append('{}: BoF overlaps with other BoF: {}'
715+
violations.append('{}: BOF overlaps with other BOF: {}'
716716
.format(self.group, other.group))
717717
cost += self.business_constraint_costs['bof_overlapping_bof']
718-
# BoFs cannot conflict with any other WGs in their area
718+
# BOFs cannot conflict with any other WGs in their area
719719
if self.is_bof and self.parent == other.parent:
720-
violations.append('{}: BoF overlaps with other session from same area: {}'
720+
violations.append('{}: BOF overlaps with other session from same area: {}'
721721
.format(self.group, other.group))
722722
cost += self.business_constraint_costs['bof_overlapping_area_wg']
723-
# BoFs cannot conflict with any area-wide meetings (of any area)
723+
# BOFs cannot conflict with any area-wide meetings (of any area)
724724
if self.is_bof and other.is_area_meeting:
725-
violations.append('{}: BoF overlaps with area meeting {}'
725+
violations.append('{}: BOF overlaps with area meeting {}'
726726
.format(self.group, other.group))
727727
cost += self.business_constraint_costs['bof_overlapping_area_meeting']
728728
# Area meetings cannot conflict with anything else in their area

0 commit comments

Comments
 (0)