Skip to content

Commit 7f7b771

Browse files
committed
Improve save questionnaire data.
See ietf-tools#970 - Legacy-Id: 5583
1 parent 139ab19 commit 7f7b771

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

ietf/nomcom/forms.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -608,20 +608,16 @@ def __init__(self, *args, **kwargs):
608608
def save(self, commit=True):
609609
feedback = super(QuestionnaireForm, self).save(commit=False)
610610

611-
nominee = self.cleaned_data.get("nominee")
612-
positions = self.cleaned_data.get("positions")
613-
614611
author = get_user_email(self.user)
615612

616613
if author:
617614
feedback.author = author
618615

619616
feedback.nomcom = self.nomcom
620-
feedback.nominee = nominee
621617
feedback.user = self.user
622618
feedback.type = FeedbackType.objects.get(slug='questio')
623619
feedback.save()
624-
feedback.positions = positions
620+
self.save_m2m()
625621

626622
class Meta:
627623
model = Feedback

ietf/nomcom/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ def feedback(request, year, public):
308308
'selected': 'feedback'}, RequestContext(request))
309309

310310

311+
@member_required(role='chair')
311312
def private_questionnaire(request, year):
312313
nomcom = get_nomcom_by_year(year)
313314
has_publickey = nomcom.public_key and True or False

0 commit comments

Comments
 (0)