Skip to content

Commit 7e8b72c

Browse files
committed
Move import scripts into importing subdirectory, move name() utility from importing/utils.py to name/utils.py
- Legacy-Id: 3098
1 parent 7d3bef3 commit 7e8b72c

6 files changed

Lines changed: 19 additions & 26 deletions

File tree

redesign/import-announcements.py renamed to redesign/importing/import-announcements.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import sys, os, re, datetime
44

5-
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
5+
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
66
sys.path = [ basedir ] + sys.path
77

88
from ietf import settings
@@ -14,8 +14,9 @@
1414
from redesign.person.models import *
1515
from redesign.group.models import *
1616
from redesign.announcements.models import *
17+
from redesign.name.utils import name
18+
from redesign.importing.utils import person_email
1719
from ietf.announcements.models import Announcement, PersonOrOrgInfo, AnnouncedTo, AnnouncedFrom
18-
from importing.utils import *
1920

2021
# assumptions:
2122
# - nomcom groups have been imported

redesign/import-document-state.py renamed to redesign/importing/import-document-state.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import sys, os, re, datetime
44

5-
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
5+
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
66
sys.path = [ basedir ] + sys.path
77

88
from ietf import settings
@@ -14,11 +14,11 @@
1414
from redesign.doc.models import *
1515
from redesign.group.models import *
1616
from redesign.name.models import *
17+
from redesign.importing.utils import person_email
18+
from redesign.name.utils import name
1719
from ietf.idtracker.models import InternetDraft, IDInternal, IESGLogin, DocumentComment, PersonOrOrgInfo, Rfc, IESGComment, IESGDiscuss, BallotInfo, Position
1820
from ietf.idrfc.models import RfcIndex, DraftVersions
1921

20-
from importing.utils import *
21-
2222
import sys
2323

2424
document_name_to_import = None
Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import sys, os
44

5-
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
5+
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
66
sys.path = [ basedir ] + sys.path
77

88
from ietf import settings
@@ -14,21 +14,13 @@
1414

1515
from redesign.group.models import *
1616
from redesign.name.models import *
17+
from redesign.name.utils import name
1718
from ietf.idtracker.models import AreaGroup, IETFWG, Area, AreaGroup, Acronym, AreaWGURL, IRTF, ChairsHistory, Role
1819

1920
# imports IETFWG, Area, AreaGroup, Acronym, IRTF
2021

2122
# also creates nomcom groups
2223

23-
# make sure we got the names
24-
def name(name_class, slug, name, desc=""):
25-
# create if it doesn't exist, set name and desc
26-
obj, _ = name_class.objects.get_or_create(slug=slug)
27-
obj.name = name
28-
obj.desc = desc
29-
obj.save()
30-
return obj
31-
3224
state_names = dict(
3325
bof=name(GroupStateName, slug="bof", name="BOF"),
3426
proposed=name(GroupStateName, slug="proposed", name="Proposed"),
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import sys, os, re, datetime
44
import unaccent
55

6-
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
6+
basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
77
sys.path = [ basedir ] + sys.path
88

99
from ietf import settings
@@ -15,9 +15,10 @@
1515
from redesign.person.models import *
1616
from redesign.group.models import *
1717
from redesign.name.models import *
18+
from redesign.name.utils import name
19+
from redesign.importing.utils import person_email
1820
from ietf.idtracker.models import IESGLogin, AreaDirector, IDAuthor, PersonOrOrgInfo, WGChair, WGEditor, WGSecretary, WGTechAdvisor, ChairsHistory, Role as OldRole, Acronym, IRTFChair
1921

20-
from importing.utils import *
2122

2223
# assumptions:
2324
# - groups have been imported

redesign/importing/utils.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
def name(name_class, slug, name, desc="", order=0):
2-
# create if it doesn't exist, set name and desc
3-
obj, _ = name_class.objects.get_or_create(slug=slug)
4-
obj.name = name
5-
obj.desc = desc
6-
obj.order = order
7-
obj.save()
8-
return obj
9-
101
def person_email(person):
112
hardcoded_emails = { 'Dinara Suleymanova': "dinaras@ietf.org" }
123

redesign/name/utils.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
def name(name_class, slug, name, desc="", order=0):
2+
# create if it doesn't exist, set name and desc
3+
obj, _ = name_class.objects.get_or_create(slug=slug)
4+
obj.name = name
5+
obj.desc = desc
6+
obj.order = order
7+
obj.save()
8+
return obj

0 commit comments

Comments
 (0)