Skip to content

Commit 7d443e5

Browse files
committed
Merged in [13955] from kivinen@iki.fi:
Changed links to previous reviews go to the doc page of the last result, not the review request page. The doc page will contain the actual review, so it has all information that is needed. Fixes ietf-tools#2090. - Legacy-Id: 13961 Note: SVN reference [13955] has been migrated to Git commit 7154166
2 parents fe7d484 + 7154166 commit 7d443e5

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

hold-for-merge

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# -*- conf-mode -*-
22

3+
/personal/sbirkholz/meeting_registration@13954
4+
/personal/sbirkholz/meeting_registration@13949
35
/personal/rcross/6.54.2.dev0@13632 # resolved differently in [13653]
46
/personal/lars/6.48.2.dev0@13124 # fails drag-and-drop test
57
/branch/proceedings/6.29.1.dev0@11850 # Merged into /branch/proceedings/6.30.1.dev0, will be merged from there

ietf/templates/group/manage_review_requests.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ <h3 class="panel-title">
7272
{% if rlatest.reviewed_rev %}
7373
Previous review of <a href="{% url "ietf.doc.views_doc.document_main" name=rlatest.doc_id rev=rlatest.reviewed_rev %}?include_text=1">{% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% endif %}-{{ rlatest.reviewed_rev }}</a>
7474
(<a href="{{ rfcdiff_base_url }}?url1={{ rlatest.doc.name }}-{{ rlatest.reviewed_rev }}&url2={{ r.doc.name }}-{{ r.doc.rev }}">diff</a>):
75-
<a href="{% url "ietf.doc.views_review.review_request" name=rlatest.doc_id request_id=rlatest.pk %}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
75+
<a href="{{ rlatest.review.get_absolute_url }}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
7676
by {{ rlatest.reviewer.person }}{% if rlatest.closed_review_request_event %} {{ rlatest.closed_review_request_event.time.date|date }}{% endif %}
7777
{% else %}
7878
Previous review of <a href="{% url "ietf.doc.views_doc.document_main" name=rlatest.doc_id %}?include_text=1">{% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% else %}this document{% endif %}</a>:

0 commit comments

Comments
 (0)