Skip to content

Commit 7d01c66

Browse files
committed
Merged in the agenda filtering improvements from jennifer@painless-security.com. This completely reworks the filtering of the IETF agenda, in order to not collide with page navigation and clean up a number of edge cases. It also reinstates the same kind of filtering for the upcoming meetings page.
- Legacy-Id: 18534
2 parents f7e1b26 + 97dd600 commit 7d01c66

16 files changed

Lines changed: 1931 additions & 426 deletions

ietf/meeting/test_data.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,9 @@ def make_meeting_test_data(meeting=None, create_interims=False):
116116
break_slot = TimeSlot.objects.create(meeting=meeting, type_id="break", location=break_room,
117117
duration=datetime.timedelta(minutes=90),
118118
time=datetime.datetime.combine(session_date, datetime.time(7,0)))
119+
plenary_slot = TimeSlot.objects.create(meeting=meeting, type_id="plenary", location=room,
120+
duration=datetime.timedelta(minutes=60),
121+
time=datetime.datetime.combine(session_date, datetime.time(11,0)))
119122
# mars WG
120123
mars = Group.objects.get(acronym='mars')
121124
mars_session = Session.objects.create(meeting=meeting, group=mars,
@@ -159,6 +162,14 @@ def make_meeting_test_data(meeting=None, create_interims=False):
159162
SchedulingEvent.objects.create(session=break_session, status_id='schedw', by=system_person)
160163
SchedTimeSessAssignment.objects.create(timeslot=break_slot, session=break_session, schedule=base_schedule)
161164

165+
# IETF Plenary
166+
plenary_session = Session.objects.create(meeting=meeting, group=Group.objects.get(acronym="ietf"),
167+
name="IETF Plenary", attendees=250,
168+
requested_duration=datetime.timedelta(minutes=60),
169+
type_id="plenary")
170+
SchedulingEvent.objects.create(session=plenary_session, status_id='schedw', by=system_person)
171+
SchedTimeSessAssignment.objects.create(timeslot=plenary_slot, session=plenary_session, schedule=schedule)
172+
162173
meeting.schedule = schedule
163174
meeting.save()
164175

@@ -209,7 +220,7 @@ def make_interim_test_data():
209220
ad = Person.objects.get(user__username='ad')
210221
RoleFactory(group=area,person=ad,name_id='ad')
211222
mars = GroupFactory(acronym='mars',parent=area,name='Martian Special Interest Group')
212-
ames = GroupFactory(acronym='ames',parent=area)
223+
ames = GroupFactory(acronym='ames',parent=area,name='Asteroid Mining Equipment Standardization Group')
213224
RoleFactory(group=mars,person__user__username='marschairman',name_id='chair')
214225
RoleFactory(group=ames,person__user__username='ameschairman',name_id='chair')
215226

ietf/meeting/tests_api.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -477,8 +477,7 @@ class TimeSlotEditingApiTests(TestCase):
477477

478478
def test_manipulate_timeslot(self):
479479
meeting = make_meeting_test_data()
480-
slot = meeting.timeslot_set.all()[0]
481-
self.assertEqual(TimeSlot.objects.get(pk=slot.pk).type_id,'regular')
480+
slot = meeting.timeslot_set.filter(type_id='regular')[0]
482481

483482
url = urlreverse("ietf.meeting.ajax.timeslot_sloturl",
484483
kwargs=dict(num=meeting.number, slotid=slot.pk))

ietf/meeting/tests_js.py

Lines changed: 503 additions & 48 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)