Skip to content

Commit 7bd647c

Browse files
committed
Don't create empty Alias records. Fixes issue ietf-tools#1603.
- Legacy-Id: 9086
1 parent a85725e commit 7bd647c

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

ietf/person/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def save(self, *args, **kwargs):
9292
))
9393
send_mail_preformatted(None, msg)
9494
self.alias_set.get_or_create(name=self.name)
95-
if self.name != self.ascii:
95+
if self.ascii and self.name != self.ascii:
9696
self.alias_set.get_or_create(name=self.ascii)
9797

9898
#this variable, if not None, may be used by url() to keep the sitefqdn.

ietf/secr/rolodex/views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ def edit(request, id):
173173
for field in ('name','ascii','ascii_short'):
174174
if field in person_form.changed_data:
175175
person.alias_set.filter(name=getattr(person,field)).delete()
176-
Alias.objects.get_or_create(person=person,name=person_form.cleaned_data[field])
176+
alias = person_form.cleaned_data[field]
177+
if alias:
178+
Alias.objects.get_or_create(person=person,name=alias)
177179

178180
person_form.save()
179181
email_formset.save()

0 commit comments

Comments
 (0)