Skip to content

Commit 7bb99a2

Browse files
committed
Distinguish between real 500 result codes, exceptions, and other results. Disable reachability tests for regular buildbot unittest runs by changing the method name.
- Legacy-Id: 858
1 parent f84bcda commit 7bb99a2

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

ietf/tests.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,8 @@ def testUrlsList(self):
295295
note("\nTesting specified URLs:")
296296
self.doUrlsTest(module.testtuples)
297297

298-
def testUrlsReachability(self):
298+
# Disable this test by not having it start with "test"
299+
def xTestUrlsReachability(self):
299300
# This test should be sorted after the other tests which retrieve URLs
300301
note("\nTesting URL reachability of %s URLs:" % len(module.reachability) )
301302
for url in module.reachability:
@@ -311,7 +312,7 @@ def testUrlsReachability(self):
311312
note("Exception for URL '%s'" % url)
312313
traceback.print_exc()
313314
self.client = Client()
314-
code = "500"
315+
code = "Exc"
315316
elif url.startswith("mailto:"):
316317
continue
317318
else:
@@ -325,14 +326,14 @@ def testUrlsReachability(self):
325326
note("Exception for URL '%s'" % url)
326327
traceback.print_exc()
327328
self.client = Client()
328-
code = "500"
329+
code = "Exc"
329330
except httplib.InvalidURL, e:
330331
note("Exception for URL '%s'" % url)
331332
traceback.print_exc()
332333
self.client = Client()
333-
code = "500"
334+
code = "Exc"
334335
else:
335-
code = "500"
336+
code = "000"
336337
if not code in ["200"]:
337338
note("Reach %3s <%s> (from %s)\n" % (code, url, source))
338339

0 commit comments

Comments
 (0)