Skip to content

Commit 7b3a62e

Browse files
committed
Moved IANA addresses that were used in more than one place into settings (which addresses a typo in one of the places the IANA eval email address was used).
Fixes bug 1124 Branch ready for merge - Legacy-Id: 6151
1 parent a4fc386 commit 7b3a62e

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

ietf/doc/views_ballot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def ballot_writeupnotes(request, name):
546546
msg = generate_issue_ballot_mail(request, doc, ballot)
547547
send_mail_preformatted(request, msg)
548548
send_mail_preformatted(request, msg, extra=extra_automation_headers(doc),
549-
override={ "To": "IANA <drafts-eval@icann.org>", "CC": None, "Bcc": None , "Reply-To": None})
549+
override={ "To": "IANA <%s>"%settings.IANA_EVAL_EMAIL, "CC": None, "Bcc": None , "Reply-To": None})
550550

551551
e = DocEvent(doc=doc, by=login)
552552
e.by = login
@@ -716,7 +716,7 @@ def approve_ballot(request, name):
716716

717717
if action == "to_announcement_list":
718718
send_mail_preformatted(request, announcement, extra=extra_automation_headers(doc),
719-
override={ "To": "IANA <drafts-approval@icann.org>", "CC": None, "Bcc": None, "Reply-To": None})
719+
override={ "To": "IANA <%s>"%settings.IANA_APPROVE_EMAIL, "CC": None, "Bcc": None, "Reply-To": None})
720720

721721
msg = infer_message(announcement)
722722
msg.by = login

ietf/doc/views_conflict_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def send_conflict_eval_email(request,review):
100100
send_mail_preformatted(request,msg)
101101
email_iana(request,
102102
review.relateddocument_set.get(relationship__slug='conflrev').target.document,
103-
'draft-eval@icann.org',
103+
settings.IANA_EVAL_EMAIL,
104104
msg)
105105

106106
class UploadForm(forms.Form):

ietf/doc/views_draft.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1063,7 +1063,7 @@ def request_publication(request, name):
10631063
send_mail_message(request, m)
10641064

10651065
# IANA copy
1066-
m.to = "IANA <drafts-approval@icann.org>"
1066+
m.to = settings.IANA_APPROVE_EMAIL
10671067
send_mail_message(request, m, extra=extra_automation_headers(doc))
10681068

10691069
e = DocEvent(doc=doc, type="requested_publication", by=request.user.get_profile())

ietf/settings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,9 @@
281281
IPR_EMAIL_TO = ['ietf-ipr@ietf.org', ]
282282
DOC_APPROVAL_EMAIL_CC = ["RFC Editor <rfc-editor@rfc-editor.org>", ]
283283

284+
IANA_EVAL_EMAIL = "drafts-eval@icann.org"
285+
IANA_APPROVE_EMAIL = "drafts-approval@icann.org"
286+
284287
# Put real password in settings_local.py
285288
IANA_SYNC_PASSWORD = "secret"
286289
IANA_SYNC_CHANGES_URL = "https://datatracker.iana.org:4443/data-tracker/changes"

0 commit comments

Comments
 (0)