Skip to content

Commit 78e4fa6

Browse files
committed
Tweak the sort order so that the minimum interval between reviews is
considered of lower importance compared to previous reviews/wishes to review the document - Legacy-Id: 12167
1 parent a216694 commit 78e4fa6

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

ietf/review/utils.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -702,18 +702,18 @@ def format_period(p):
702702
if periods:
703703
explanations.append(", ".join(format_period(p) for p in periods))
704704

705-
# minimum interval between reviews
706-
days_needed = days_needed_for_reviewers.get(e.person_id, 0)
707-
scores.append(-days_needed)
708-
if days_needed > 0:
709-
explanations.append("max frequency exceeded, ready in {} {}".format(days_needed, "day" if days_needed == 1 else "days"))
710-
711705
# misc
712706
add_boolean_score(+1, e.pk in has_reviewed_previous, "reviewed document before")
713707
add_boolean_score(+1, e.person_id in wish_to_review, "wishes to review document")
714708
add_boolean_score(-1, e.pk in connections, connections.get(e.pk)) # reviewer is somehow connected: bad
715709
add_boolean_score(-1, settings.filter_re and any(re.search(settings.filter_re, n) for n in aliases), "filter regexp matches")
716710

711+
# minimum interval between reviews
712+
days_needed = days_needed_for_reviewers.get(e.person_id, 0)
713+
scores.append(-days_needed)
714+
if days_needed > 0:
715+
explanations.append("max frequency exceeded, ready in {} {}".format(days_needed, "day" if days_needed == 1 else "days"))
716+
717717
# skip next
718718
scores.append(-settings.skip_next)
719719
if settings.skip_next > 0:

0 commit comments

Comments
 (0)