Skip to content

Commit 7649397

Browse files
committed
Better app and model names. Some model hygiene. Added admin.
- Legacy-Id: 9993
1 parent c0acadf commit 7649397

21 files changed

Lines changed: 164 additions & 128 deletions

ietf/doc/mails.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from ietf.person.models import Person
1515
from ietf.group.models import Group, Role
1616
from ietf.doc.models import Document
17-
from ietf.eventmail.utils import gather_addresses
17+
from ietf.mailtoken.utils import gather_addresses
1818

1919
def email_state_changed(request, doc, text):
2020
to = [x.strip() for x in doc.notify.replace(';', ',').split(',')]

ietf/doc/tests_ballot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from ietf.utils.mail import outbox
1616
from ietf.utils.test_data import make_test_data
1717
from ietf.utils.test_utils import login_testing_unauthorized
18-
from ietf.eventmail.utils import gather_addresses
18+
from ietf.mailtoken.utils import gather_addresses
1919

2020

2121
class EditPositionTests(TestCase):

ietf/doc/views_ballot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from ietf.name.models import BallotPositionName
2828
from ietf.person.models import Person
2929
from ietf.utils.mail import send_mail_text, send_mail_preformatted
30-
from ietf.eventmail.utils import gather_addresses
30+
from ietf.mailtoken.utils import gather_addresses
3131

3232
BALLOT_CHOICES = (("yes", "Yes"),
3333
("noobj", "No Objection"),

ietf/doc/views_draft.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
from ietf.secr.lib.template import jsonapi
3838
from ietf.utils.mail import send_mail, send_mail_message
3939
from ietf.utils.textupload import get_cleaned_text_file_content
40-
from ietf.eventmail.utils import gather_addresses
40+
from ietf.mailtoken.utils import gather_addresses
4141

4242
class ChangeStateForm(forms.Form):
4343
state = forms.ModelChoiceField(State.objects.filter(used=True, type="draft-iesg"), empty_label=None, required=True)

ietf/eventmail/urls.py

Lines changed: 0 additions & 11 deletions
This file was deleted.

ietf/eventmail/views.py

Lines changed: 0 additions & 24 deletions
This file was deleted.

ietf/mailtoken/admin.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
from django.contrib import admin
2+
3+
from ietf.mailtoken.models import MailToken, Recipient
4+
5+
class RecipientAdmin(admin.ModelAdmin):
6+
list_display = [ 'slug', 'desc', 'template', 'has_code', ]
7+
def has_code(self, obj):
8+
return hasattr(obj,'gather_%s'%obj.slug)
9+
has_code.boolean = True
10+
admin.site.register(Recipient, RecipientAdmin)
11+
12+
13+
class MailTokenAdmin(admin.ModelAdmin):
14+
list_display = [ 'slug', 'desc', ]
15+
filter_horizontal = [ 'recipients' ]
16+
admin.site.register(MailToken, MailTokenAdmin)
17+
Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,32 @@ class Migration(migrations.Migration):
1111

1212
operations = [
1313
migrations.CreateModel(
14-
name='Ingredient',
14+
name='MailToken',
1515
fields=[
1616
('slug', models.CharField(max_length=32, serialize=False, primary_key=True)),
1717
('desc', models.TextField(blank=True)),
18-
('template', models.CharField(max_length=512, null=True, blank=True)),
1918
],
2019
options={
20+
'ordering': ['slug'],
2121
},
2222
bases=(models.Model,),
2323
),
2424
migrations.CreateModel(
25-
name='Recipe',
25+
name='Recipient',
2626
fields=[
2727
('slug', models.CharField(max_length=32, serialize=False, primary_key=True)),
2828
('desc', models.TextField(blank=True)),
29-
('ingredients', models.ManyToManyField(to='eventmail.Ingredient', null=True, blank=True)),
29+
('template', models.CharField(max_length=512, null=True, blank=True)),
3030
],
3131
options={
32+
'ordering': ['slug'],
3233
},
3334
bases=(models.Model,),
3435
),
36+
migrations.AddField(
37+
model_name='mailtoken',
38+
name='recipients',
39+
field=models.ManyToManyField(to='mailtoken.Recipient', null=True, blank=True),
40+
preserve_default=True,
41+
),
3542
]

0 commit comments

Comments
 (0)