Skip to content

Commit 75ce7d6

Browse files
committed
Merged in [8204] from rjsparks@nostrum.com:
Improves how many href urls are constructed. Updates ticket ietf-tools#1459. - Legacy-Id: 8310 Note: SVN reference [8204] has been migrated to Git commit ffa20b1
2 parents e98e6c3 + ffa20b1 commit 75ce7d6

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -566,11 +566,9 @@ def document_history(request, name):
566566
if name.startswith("charter"):
567567
url = request.build_absolute_uri(urlreverse("charter_with_milestones_txt", kwargs=dict(name=e.doc.name, rev=e.rev)))
568568
elif name.startswith("conflict-review"):
569-
h = find_history_active_at(e.doc, e.time)
570-
url = settings.CONFLICT_REVIEW_TXT_URL + ("%s-%s.txt" % ((h or doc).canonical_name(), e.rev))
569+
url = find_history_active_at(e.doc, e.time).href()
571570
elif name.startswith("status-change"):
572-
h = find_history_active_at(e.doc, e.time)
573-
url = settings.STATUS_CHANGE_TXT_URL + ("%s-%s.txt" % ((h or doc).canonical_name(), e.rev))
571+
url = find_history_active_at(e.doc, e.time).href()
574572
elif name.startswith("draft") or name.startswith("rfc"):
575573
# rfcdiff tool has special support for IDs
576574
url = e.doc.name + "-" + e.rev

ietf/settings.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,11 +279,8 @@ def skip_unreadable_post(record):
279279
INTERNET_DRAFT_PDF_PATH = '/a/www/ietf-datatracker/pdf/'
280280
RFC_PATH = '/a/www/ietf-ftp/rfc/'
281281
CHARTER_PATH = '/a/www/ietf-ftp/charter/'
282-
CHARTER_TXT_URL = 'http://www.ietf.org/charter/'
283282
CONFLICT_REVIEW_PATH = '/a/www/ietf-ftp/conflict-reviews'
284-
CONFLICT_REVIEW_TXT_URL = 'http://www.ietf.org/cr/'
285283
STATUS_CHANGE_PATH = '/a/www/ietf-ftp/status-changes'
286-
STATUS_CHANGE_TXT_URL = 'http://www.ietf.org/sc/'
287284
AGENDA_PATH = '/a/www/www6s/proceedings/'
288285
IPR_DOCUMENT_PATH = '/a/www/ietf-ftp/ietf/IPR/'
289286
IESG_TASK_FILE = '/a/www/www6/iesg/internal/task.txt'
@@ -307,6 +304,8 @@ def skip_unreadable_post(record):
307304
#"liai-att": None
308305
#"liaison": None
309306
"slides": 'http://www.ietf.org/slides/{doc.name}-{doc.rev}',
307+
"conflrev": "http://www.ietf.org/cr/{doc.name}-{doc.rev}.txt",
308+
"statchg": "http://www.ietf.org/sc/{doc.name}-{doc.rev}.txt",
310309
}
311310

312311
MEETING_DOC_HREFS = {

ietf/templates/iesg/agenda_doc.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
{% with doc.rfc_number as rfc_number %}
1010
{% if rfc_number %}
1111
<a href="http://www.rfc-editor.org/rfc/rfc{{rfc_number}}/">[txt]</a>
12-
{% else %}
12+
{% elif doc.type.slug == 'draft' %}
1313
<a href="http://www.ietf.org/id/{{doc.name}}-{{doc.rev}}.txt">[txt]</a>
14+
{% else %}
15+
<a href="{{doc.href}}">[txt]</a>
1416
{% endif %}
1517
{% endwith %}
1618

0 commit comments

Comments
 (0)