Skip to content

Commit 7462ade

Browse files
committed
Summary: Cleanup markup for navtabs a little, use CSS to add margin
instead of empty paragraph - Legacy-Id: 8919
1 parent 212d7e8 commit 7462ade

9 files changed

Lines changed: 13 additions & 17 deletions

File tree

ietf/templates/community/manage_clist.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,14 @@ <h1>{{ cl.long_name }}</h1>
99

1010
{% bootstrap_messages %}
1111

12-
<ul class="nav nav-tabs nav-memory">
12+
<ul class="nav nav-tabs nav-memory" role="tablist">
1313
<li class="active"><a href="#view" data-toggle="tab">Documents</a></li>
1414
<li><a href="#documents" data-toggle="tab">Explicitly added</a></li>
1515
<li><a href="#rules" data-toggle="tab">Rules</a></li>
1616
<li><a href="#custom" data-toggle="tab">Display customization</a></li>
1717
<li><a href="#info" data-toggle="tab">Exports</a></li>
1818
</ul>
1919

20-
<p></p>
21-
2220
<div class="tab-content">
2321
<div class="tab-pane active" id="view">
2422
{% include "community/view_list.html" %}

ietf/templates/doc/document_top.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22

33
<h1>{{ doc.title }}<br><small>{{ name }}</small></h1>
44

5-
<ul class="nav nav-tabs">
5+
<ul class="nav nav-tabs" role="tablist">
66
{% for name, t, url, active, tooltip in tabs %}
77
<li {% if tooltip %}title="{{tooltip}}"{% endif %} class="{% if t == selected %}active {% endif %}{% if not active %}disabled {% endif %}">
88
<a {% if active %}href="{{ url }}"{% endif %}>{{ name|capfirst_allcaps }}</a>
99
</li>
1010
{% endfor %}
1111
</ul>
12-
<p></p>

ietf/templates/group/group_base.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,14 @@ <h1>{{ group.name}} ({{ group.acronym }})
1515
{% endif %}
1616
</h1>
1717

18-
<ul class="nav nav-tabs">
18+
<ul class="nav nav-tabs" role="tablist">
1919
{% for name, url in menu_entries %}
2020
<li {% if selected_menu_entry == name.lower %}class="active"{% endif %}>
2121
<a href="{{ url }}">{{ name }}</a>
2222
</li>
2323
{% endfor %}
2424
</ul>
2525

26-
<p></p>
27-
2826
{% if menu_actions %}
2927
<div class="buttonlist">
3028
{% for name, url in menu_actions %}

ietf/templates/nomcom/nomcom_private_base.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ <h1>NomCom {{ year }} <small>Private area</small></h1>
4343
</li>
4444
{% endif %}
4545
</ul>
46-
<p></p>
4746

4847
{% block nomcom_content %}
4948
{% endblock %}

ietf/templates/nomcom/nomcom_public_base.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ <h1>NomCom {{ year }}</h1>
1717
<li {% if selected == "requirements" %}class="active"{% endif %}><a href="{% url "nomcom_requirements" year %}">Desired expertise</a></li>
1818
<li {% if selected == "questionnaires" %}class="active"{% endif %}><a href="{% url "nomcom_questionnaires" year %}">Questionnaires</a></li>
1919
</ul>
20-
<p></p>
2120

2221
{% block nomcom_content %}
2322
{% endblock %}

ietf/templates/nomcom/view_feedback_nominee.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ <h2>Feedback about {{ nominee }} </h2>
5454
{% endfor %}
5555
</div>
5656

57-
<p></p>
5857
<a class="btn btn-default" href="{% url "nomcom_view_feedback" year %}">Back</a>
5958

6059
{% endblock %}

ietf/templates/nomcom/view_feedback_unrelated.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ <h2>Feedback not related to nominees</h2>
4848
{% endfor %}
4949
</div>
5050

51-
<p></p>
52-
<a class="btn btn-default" href="{% url "nomcom_view_feedback" year %}">Back</a>
51+
<p>
52+
<a class="btn btn-default" href="{% url "nomcom_view_feedback" year %}">Back</a>
53+
</p>
5354
{% endblock %}

ietf/templates/submit/submit_base.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{% block content %}
88
<h1>Internet-Draft submission </h1>
99

10-
<ul class="nav nav-tabs">
10+
<ul class="nav nav-tabs" role="tablist">
1111
<li {% if selected == "index" %}class="active"{% endif %}>
1212
<a href="{% url "submit_upload_submission" %}">Upload</a>
1313
</li>
@@ -25,8 +25,6 @@ <h1>Internet-Draft submission </h1>
2525
</li>
2626
</ul>
2727

28-
<p></p>
29-
3028
{% block submit_content %}
3129
{% endblock %}
3230

static/facelift/css/ietf.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,12 @@ body { padding-top: 70px; }
8282
.panel-blank { color: #555; }
8383
.panel-blank > .panel-heading { background-color: #eee; }
8484

85-
/* Style required form field labels - 2217 = &lowast; */
85+
/* Required form field labels - 2217 = &lowast; */
8686
label.required:after { content: "\2217"; color: #a94442; font-weight: bold; }
8787

88+
/* Add some margin to tabs */
89+
.nav-tabs[role=tablist] { margin-bottom: 0.7em; }
90+
8891
/* Styles needed for the ballot table */
8992
.position-discuss,
9093
.position-block { background-color: #d9534f; }
@@ -250,4 +253,6 @@ pre { line-height: 1.214; }
250253

251254
/* IPR */
252255

256+
#ipr-details dl.dl-horizontal dt { white-space: normal; }
257+
253258
.ipr-form .draft-row.template { display: none }

0 commit comments

Comments
 (0)