Skip to content

Commit 729b52f

Browse files
committed
Added a switchover date (currently July 6th) for Etherpad to CodiMD use, and modified views and templates accordingly.
- Legacy-Id: 18063
1 parent 6a38234 commit 729b52f

5 files changed

Lines changed: 80 additions & 7 deletions

File tree

changelog

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,55 @@
1+
ietfdb (7.5.0) ietf; urgency=medium
2+
3+
**Django 2.1 upgrade and bugfixes**
4+
5+
* Merged in [18036] from rjsparks@nostrum.com:
6+
Tweaked the title of the page used to complete reviews. Fixes #2767.
7+
8+
* Merged in [18037] from rjsparks@nostrum.com:
9+
Removed abandoned charters from any future telechats. Fixes #3003.
10+
11+
* Separated the session cache from the default cache, using slightly
12+
different settings, in order to not drop sessions when a new release is
13+
deployed.
14+
15+
* Added a default logger and level for 'django.security' log items, to
16+
route them to our regular syslog. This will give us more information about
17+
failures to retrieve session info, and also things like 404 responses,
18+
which will already be captured in the apache log but with less info. May
19+
need revisiting if it proves to cause excessive logging.
20+
21+
* Fixed a problem with the code to update a missing person record
22+
association in a meeting registration record.
23+
24+
* Fixed an issue in a test function that could occasionally fail
25+
incorrectly.
26+
27+
* Removed the wsgi.py warning about starting without virtualenv; this is
28+
normal under Py3.
29+
30+
* Fixed a problem with the handling of multiple registrations for the
31+
same person and meeting in api_new_meeting_registration().
32+
33+
Django 2.1 transition changes:
34+
35+
* Changed NullBoleanField() to BooleanField(null=True), according to the
36+
2.1 upgrade recommendations.
37+
38+
* Changed the removed django.contrib.auth.views.logout to LogoutView.
39+
40+
* Adjusted to the changed signature of admin.utils.get_deleted_objects()
41+
42+
* Adjusted the code to the attribute name change from ._size to .size in
43+
file upload objects.
44+
45+
* Updated the requirements for Django 2.1
46+
47+
* The .render() method of widgets now must accept an additional keyword
48+
argument 'renderer'; adjusted the code accordingly (including a library
49+
patch -- pull request also submitted).
50+
51+
-- Henrik Levkowetz <henrik@levkowetz.com> 24 Jun 2020 20:45:14 +0000
52+
153
ietfdb (7.4.0) ietf; urgency=medium
254

355
**Test suite and OpenID improvements**

ietf/meeting/views.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,6 +957,7 @@ def agenda(request, num=None, name=None, base=None, ext=None, owner=None, utc=""
957957
"group_parents": group_parents,
958958
"now": datetime.datetime.now(),
959959
"is_current_meeting": bool(num == get_current_ietf_meeting_num()),
960+
"use_codimd": True if meeting.date>=settings.MEETING_USES_CODIMD_DATE else False,
960961
}, content_type=mimetype[ext])
961962

962963
# If the agenda is for the current meeting, only cache for 2 minutes
@@ -1625,6 +1626,7 @@ def session_details(request, num, acronym):
16251626
'can_view_request': can_view_request,
16261627
'thisweek': datetime.date.today()-datetime.timedelta(days=7),
16271628
'now': datetime.datetime.now(),
1629+
'use_codimd': True if meeting.date>=settings.MEETING_USES_CODIMD_DATE else False,
16281630
})
16291631

16301632
class SessionDraftsForm(forms.Form):
@@ -2733,7 +2735,8 @@ def upcoming(request):
27332735
'menu_actions': actions,
27342736
'menu_entries': menu_entries,
27352737
'selected_menu_entry': selected_menu_entry,
2736-
'now': datetime.datetime.now()
2738+
'now': datetime.datetime.now(),
2739+
'use_codimd': True if datetime.date.today()>=settings.MEETING_USES_CODIMD_DATE else False,
27372740
})
27382741

27392742

ietf/settings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,6 +905,8 @@ def skip_unreadable_post(record):
905905
FLOORPLAN_MEDIA_DIR = 'floor'
906906
FLOORPLAN_DIR = os.path.join(MEDIA_ROOT, FLOORPLAN_MEDIA_DIR)
907907

908+
MEETING_USES_CODIMD_DATE = datetime.date(2020,7,6)
909+
908910
# === OpenID Connect Provide Related Settings ==================================
909911

910912
# Used by django-oidc-provider

ietf/templates/meeting/interim_session_buttons.html

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,18 @@
1414
<a class="" href="/meeting/{{ meeting.number }}/agenda/{{session.historic_group.acronym}}-drafts.pdf" title="Download meeting materials as PDF file"><span class="fa fa-fw fa-file-pdf-o"></span></a>
1515
{% endif %}
1616
<!-- etherpad -->
17-
{% if item.timeslot.type.slug == 'plenary' %}
18-
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-plenary?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
17+
{% if use_codimd %}
18+
{% if item.timeslot.type.slug == 'plenary' %}
19+
<a class="" href="https://codimd.ietf.org/notes-ietf-{{ meeting.number }}-plenary title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
20+
{% else %}
21+
<a class="" href="https://codimd.ietf.org/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
22+
{% endif %}
1923
{% else %}
20-
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
24+
{% if item.timeslot.type.slug == 'plenary' %}
25+
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-plenary?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
26+
{% else %}
27+
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
28+
{% endif %}
2129
{% endif %}
2230

2331
{# show stream buttons up till end of session, then show archive buttons #}

ietf/templates/meeting/session_buttons_include.html

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,18 @@
1616
{% endif %}
1717

1818
<!-- etherpad -->
19-
{% if item.timeslot.type.slug == 'plenary' %}
20-
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-plenary?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
19+
{% if use_codimd %}
20+
{% if item.timeslot.type.slug == 'plenary' %}
21+
<a class="" href="https://codimd.ietf.org/notes-ietf-{{ meeting.number }}-plenary title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
22+
{% else %}
23+
<a class="" href="https://codimd.ietf.org/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
24+
{% endif %}
2125
{% else %}
22-
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
26+
{% if item.timeslot.type.slug == 'plenary' %}
27+
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-plenary?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
28+
{% else %}
29+
<a class="" href="https://etherpad.ietf.org:9009/p/notes-ietf-{{ meeting.number }}-{{session.historic_group.acronym}}?useMonospaceFont=true" title="Etherpad for note-takers"><span class="fa fa-fw fa-edit"></span></a>
30+
{% endif %}
2331
{% endif %}
2432

2533
{# show stream buttons up till end of session, then show archive buttons #}

0 commit comments

Comments
 (0)