Skip to content

Commit 708c3a4

Browse files
committed
Look at intended_std_level instead of looking at the indefinite
article when determining document/protocol action status, also avoid putting stuff in a list that has been taken directly by reference from the settings - Legacy-Id: 3963
1 parent f6f7e4b commit 708c3a4

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

ietf/idrfc/mails.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -297,13 +297,14 @@ def generate_approval_mailREDESIGN(request, doc):
297297
def generate_approval_mail_approved(request, doc):
298298
doc.full_status = full_intended_status(doc.intended_std_level)
299299
status = doc.full_status.replace("a ", "").replace("an ", "")
300-
301-
if "an " in status:
302-
action_type = "Document"
303-
else:
300+
301+
if doc.intended_std_level_id in ("std", "ds", "ps", "bcp"):
304302
action_type = "Protocol"
305-
306-
cc = settings.DOC_APPROVAL_EMAIL_CC
303+
else:
304+
action_type = "Document"
305+
306+
cc = []
307+
cc.extend(settings.DOC_APPROVAL_EMAIL_CC)
307308

308309
# the second check catches some area working groups (like
309310
# Transport Area Working Group)

0 commit comments

Comments
 (0)