Skip to content

Commit 705322f

Browse files
committed
Add a select_related to role extraction in wginfo to reduce number of
DB queries a bit - Legacy-Id: 6247
1 parent b4988b2 commit 705322f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/wginfo/views.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@
5353

5454
def fill_in_charter_info(group, include_drafts=False):
5555
group.areadirector = group.ad.role_email("ad", group.parent) if group.ad else None
56-
group.chairs = Email.objects.filter(role__group=group, role__name="chair")
57-
group.techadvisors = Email.objects.filter(role__group=group, role__name="techadv")
58-
group.editors = Email.objects.filter(role__group=group, role__name="editor")
59-
group.secretaries = Email.objects.filter(role__group=group, role__name="secr")
56+
group.chairs = Email.objects.filter(role__group=group, role__name="chair").select_related("person")
57+
group.techadvisors = Email.objects.filter(role__group=group, role__name="techadv").select_related("person")
58+
group.editors = Email.objects.filter(role__group=group, role__name="editor").select_related("person")
59+
group.secretaries = Email.objects.filter(role__group=group, role__name="secr").select_related("person")
6060
milestone_state = "charter" if group.state_id == "proposed" else "active"
6161
group.milestones = group.groupmilestone_set.filter(state=milestone_state).order_by('due')
6262

@@ -275,7 +275,7 @@ def group_charter(request, acronym):
275275
group = get_object_or_404(Group, type="wg", acronym=acronym)
276276

277277
fill_in_charter_info(group, include_drafts=False)
278-
group.delegates = Email.objects.filter(role__group=group, role__name="delegate")
278+
group.delegates = Email.objects.filter(role__group=group, role__name="delegate").select_related("person")
279279

280280
e = group.latest_event(type__in=("changed_state", "requested_close",))
281281
requested_close = group.state_id != "conclude" and e and e.type == "requested_close"

0 commit comments

Comments
 (0)