Skip to content

Commit 703d999

Browse files
committed
Summary: Fix bugs in implementation of add/remove from community list JS
- Legacy-Id: 8967
1 parent a5aa58e commit 703d999

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

ietf/templates/doc/document_draft.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@
338338
{% endif %}
339339
{% if user.is_authenticated %}
340340
{% if tracking_document %}
341-
<a class="btn btn-default btn-xs" href="{% url "community_remove_track_document" doc.name %}" title="Remove from your personal ID list"><span class="fa fa-bookmark-o"></span> Untrack</a>
341+
<a class="btn btn-default btn-xs community-list-add-remove-doc" href="{% url "community_remove_track_document" doc.name %}" title="Remove from your personal ID list"><span class="fa fa-bookmark-o"></span> Untrack</a>
342342
{% else %}
343-
<a class="btn btn-default btn-xs" href="{% url "community_add_track_document" doc.name %}" title="Add to your personal ID list"><span class="fa fa-bookmark"></span> Track</a>
343+
<a class="btn btn-default btn-xs community-list-add-remove-doc" href="{% url "community_add_track_document" doc.name %}" title="Add to your personal ID list"><span class="fa fa-bookmark"></span> Track</a>
344344
{% endif %}
345345
{% endif %}
346346

ietf/templates/doc/search/search_result_row.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
<td>
77
{% if user.is_authenticated %}
88
{% if not doc.name in have_doc_status %}
9-
{% elif doc.name in doc_is_tracked %}
10-
<a href="{% url "community_remove_track_document" doc.name %}" title="Remove from your personal ID list">
11-
<span class="fa fa-bookmark-o"></span>
9+
{% elif doc.name in doc_is_tracked %}
10+
<a href="{% url "community_remove_track_document" doc.name %}" class="community-list-add-remove-doc" title="Remove from your personal ID list">
11+
<span class="fa fa-bookmark-o"></span>
1212
</a>
1313
{% else %}
14-
<a href="{% url "community_add_track_document" doc.name %}" title="Add to your personal ID list">
14+
<a href="{% url "community_add_track_document" doc.name %}" class="community-list-add-remove-doc" title="Add to your personal ID list">
1515
<span class="fa fa-bookmark"></span>
1616
</a>
1717
{% endif %}

static/facelift/js/ietf.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ $(document).ready(function () {
100100
}
101101

102102
// search results
103-
$('.addtolist a').click(function(e) {
103+
$('.community-list-add-remove-doc').click(function(e) {
104104
e.preventDefault();
105105
var trigger = $(this);
106106
$.ajax({
@@ -110,8 +110,10 @@ $(document).ready(function () {
110110
dataType: 'json',
111111
success: function(response){
112112
if (response.success) {
113-
trigger.replaceWith('<span class="fa fa-tag text-danger"></span>');
114-
}
113+
trigger.parent().find(".tooltip").remove();
114+
// it would be neater to swap in remove link
115+
trigger.replaceWith('<span class="fa fa-tag text-danger"></span>');
116+
}
115117
}
116118
});
117119
});

0 commit comments

Comments
 (0)