Skip to content

Commit 6f61153

Browse files
committed
Fixed bug in display of conflict review targets after they become RFCs. Fixed views of previous version of status changes
- Legacy-Id: 5429
1 parent 33e2a07 commit 6f61153

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

ietf/idrfc/views_doc.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,13 @@ def document_main(request, name, rev=None):
204204
ballot_summary = None
205205
if doc.get_state_slug() in ("iesgeval"):
206206
ballot_summary = needed_ballot_positions(doc, doc.active_ballot().active_ad_positions().values())
207+
208+
if isinstance(doc,Document):
209+
sorted_relations=doc.relateddocument_set.all().order_by('relationship__name')
210+
elif isinstance(doc,DocHistory):
211+
sorted_relations=doc.relateddochistory_set.all().order_by('relationship__name')
212+
else:
213+
sorted_relations=None
207214

208215
return render_to_response("idrfc/document_status_change.html",
209216
dict(doc=doc,
@@ -214,7 +221,7 @@ def document_main(request, name, rev=None):
214221
telechat=telechat,
215222
ballot_summary=ballot_summary,
216223
approved_states=('appr-pend','appr-sent'),
217-
sorted_relations=doc.relateddocument_set.all().order_by('relationship__name'),
224+
sorted_relations=sorted_relations,
218225
),
219226
context_instance=RequestContext(request))
220227

ietf/templates/idrfc/document_conflict_review.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% load ietf_filters %}
44

5-
{% block title %}{{ doc.canonical_name }}-{{ doc.rev }}{% endblock %}
5+
{% block title %}{{ doc.name }}-{{ doc.rev }}{% endblock %}
66

77
{% block pagehead %}
88
<link rel="stylesheet" type="text/css" href="/css/doc.css"></link>
@@ -24,7 +24,7 @@
2424
<div>
2525
{% if snapshot %}Snapshot of{% endif %}
2626
{% if doc.get_state_slug not in approved_states %}Proposed{% endif %}
27-
IESG Conflict Review for the {{conflictdoc.stream}} document: <a href="{% url doc_view name=conflictdoc.canonical_name %}">{{ conflictdoc.canonical_name }}-{{ conflictdoc.rev }}</a>
27+
IESG Conflict Review for the {{conflictdoc.stream}} document: <a href="{% url doc_view name=conflictdoc.canonical_name %}">{{ conflictdoc.canonical_name }}{% if conflictdoc.get_state_slug != 'rfc' %}-{{ conflictdoc.rev }}{% endif %}</a>
2828
</div>
2929

3030
<table id="metatable" width="100%">
@@ -100,7 +100,7 @@
100100

101101
</div>
102102

103-
<h3>Conflict Review for {{ conflictdoc.canonical_name }}-{{ conflictdoc.rev }}
103+
<h3>Conflict Review for {{ conflictdoc.name }}-{{ conflictdoc.rev }}
104104

105105
{% if not snapshot and user|has_role:"Area Director,Secretariat" and doc.get_state_slug != 'apprsent' %}
106106
<a class="edit" href="{% url conflict_review_submit name=doc.name %}">Change conflict review text</a>

0 commit comments

Comments
 (0)