Skip to content

Commit 6deac8e

Browse files
committed
Merged in [9524] from lars@netapp.com:
Add some shim js libraries for IE8 and earlier (see http://getbootstrap.com/getting-started/#template) Fix HTML structural errors in the template. Wrap some HTML comments into Django comments, so they don't get sent to the client. - Legacy-Id: 9539 Note: SVN reference [9524] has been migrated to Git commit 6f2e9f7
2 parents d30981d + 6f2e9f7 commit 6deac8e

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

ietf/templates/base.html

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99
<link href="/fonts/PTMono/stylesheet.css" rel='stylesheet' type='text/css'>
1010
<link href="/fonts/PTSans/stylesheet.css" rel='stylesheet' type='text/css'>
1111
<link href="/fonts/PTSerif/stylesheet.css" rel='stylesheet' type='text/css'>
12+
{% comment %}
1213
<!-- Halloween
1314
<link href='http://fonts.googleapis.com/css?family=IM+Fell+English+SC|IM+Fell+DW+Pica:400,400italic|Nova+Mono|IM+Fell+English:400,400italic&subset=latin-ext,latin' rel='stylesheet' type='text/css'>
1415
-->
16+
{% endcomment %}
1517

1618
<link rel="stylesheet" href="/css/bootstrap.min.css">
1719
<link rel="stylesheet" href="/css/bootstrap-theme.min.css">
@@ -21,6 +23,10 @@
2123
{% block morecss %}{% endblock %}
2224
</style>
2325

26+
<!--[if lt IE 9]>
27+
<script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
28+
<script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
29+
<![endif]-->
2430
{% block pagehead %}{% endblock %}
2531

2632
{% if server_mode and server_mode == "production" %}
@@ -32,7 +38,6 @@
3238
</head>
3339

3440
<body {% block bodyAttrs %}{%endblock%} data-group-menu-data-url="{% url "group_menu_data" %}">
35-
<!-- Removing the amp|smartypants filter as it increases the rendering time with about 50% -->
3641
<nav class="navbar {% if server_mode and server_mode == "production" %}navbar-inverse{% else %}navbar-default{% endif %} navbar-fixed-top" role="navigation">
3742
<div class="container-fluid">
3843
<div class="navbar-header">
@@ -43,10 +48,10 @@
4348
<span class="icon-bar"></span>
4449
</button>
4550
<a class="navbar-brand" href="/">
46-
<img alt="IETF Logo" src="/images/ietflogo-small-transparent.png"></img>
51+
<img alt="IETF Logo" src="/images/ietflogo-small-transparent.png">
4752
{% if not user.is_authenticated %}
4853
<div style="display: inline; vertical-align: top; padding-left: 1em;">
49-
{% if server_mode and server_mode == "production" %}
54+
{% if server_mode and server_mode == "production" %}
5055
Datatracker
5156
{% else %}
5257
<b><i>Development mode</i></b>
@@ -125,7 +130,6 @@
125130
<a href="//www.iana.org/" class="padded">IANA</a>
126131
</div>
127132
</div>
128-
</footer>
129133

130134
<footer class="row">
131135
<div class="col-md-12">
@@ -152,8 +156,10 @@
152156
</div>
153157
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js"></script>
154158
<script>window.jQuery || document.write('<script src="/js/lib/jquery-1.11.2.min.js"><\/script>')</script>
159+
{% comment %}
155160
<!-- Remove the *-nojs attributes if we are running js. This depends on jQuery's removeClass(): -->
156161
<!-- Do this as early as possible (after loading the page and jQuery) to avoid rendering changes -->
162+
{% endcomment %}
157163
<script>$(".visible-nojs").removeClass("visible-nojs");</script>
158164
<script>$(".hidden-nojs").removeClass("hidden-nojs");</script>
159165
<script src="/js/lib/jquery.cookie.min.js"></script>

ready-for-merge

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77

88
# --- Add entries at the top ---
99

10-
personal/lars/6.0.2.dev0@9523:9526
10+
personal/lars/6.0.2.dev0@9526
11+
personal/lars/6.0.2.dev0@9525
12+
personal/lars/6.0.2.dev0@9524
1113
personal/willem/v5.12.4.dev0@9316
1214
branch/iola/facelift-r8876@8970 Test crawler speed-up
1315
branch/iola/facelift-r8510@8733

0 commit comments

Comments
 (0)