Skip to content

Commit 6c8df95

Browse files
committed
Close imported review requests that are past IESG approval
automatically as overtaken by events - Legacy-Id: 11637
1 parent f7eeb1f commit 6c8df95

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

ietf/review/import_from_review_tool.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,17 @@ def parse_timestamp(t):
233233

234234
# FIXME: add log entries
235235
# FIXME: add review from reviewurl
236+
# FIXME: do something about missing result
237+
236238
# adcomments IGNORED
237239
# lccomments IGNORED
238240
# nits IGNORED
239241
# reviewurl review.external_url
240242

241243
#print meta and meta[0], telechat, lcend, req.type
242244

243-
print "imported review", row.reviewid, "as", req.pk, req.time, req.deadline, req.type, req.doc_id
245+
if req.state_id == "requested" and req.doc.get_state_slug("draft-iesg") in ["approved", "ann", "rfcqueue", "pub"]:
246+
req.state = states["overtaken"]
247+
req.save()
248+
249+
print "imported review", row.reviewid, "as", req.pk, req.time, req.deadline, req.type, req.doc_id, req.state, req.doc.get_state_slug("draft-iesg")

0 commit comments

Comments
 (0)