Skip to content

Commit 6bdf6ff

Browse files
committed
Changed some tests to use unicontent(r) instead of r.content, which decodes non-ascii content according to the response charset.
- Legacy-Id: 13189
1 parent acb8345 commit 6bdf6ff

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

ietf/community/tests.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
from django.urls import reverse as urlreverse
66
from django.contrib.auth.models import User
77

8+
import debug # pyflakes:ignore
9+
810
from ietf.community.models import CommunityList, SearchRule, EmailSubscription
911
from ietf.community.utils import docs_matching_community_list_rule, community_list_rules_matching_doc
1012
from ietf.community.utils import reset_name_contains_index_for_rule
@@ -14,7 +16,7 @@
1416
from ietf.doc.utils import add_state_change_event
1517
from ietf.person.models import Person, Email
1618
from ietf.utils.test_data import make_test_data
17-
from ietf.utils.test_utils import login_testing_unauthorized, TestCase
19+
from ietf.utils.test_utils import login_testing_unauthorized, TestCase, unicontent
1820
from ietf.utils.mail import outbox
1921
from ietf.group.factories import GroupFactory
2022
from ietf.person.factories import PersonFactory
@@ -83,7 +85,7 @@ def test_view_list(self):
8385
)
8486
r = self.client.get(url)
8587
self.assertEqual(r.status_code, 200)
86-
self.assertTrue(draft.name in r.content)
88+
self.assertTrue(draft.name in unicontent(r))
8789

8890
def test_manage_personal_list(self):
8991
draft = make_test_data()
@@ -103,7 +105,7 @@ def test_manage_personal_list(self):
103105
# document shows up on GET
104106
r = self.client.get(url)
105107
self.assertEqual(r.status_code, 200)
106-
self.assertTrue(draft.name in r.content)
108+
self.assertTrue(draft.name in unicontent(r))
107109

108110
# remove document
109111
r = self.client.post(url, { "action": "remove_document", "document": draft.pk })
@@ -240,7 +242,7 @@ def test_csv(self):
240242
r = self.client.get(url)
241243
self.assertEqual(r.status_code, 200)
242244
# this is a simple-minded test, we don't actually check the fields
243-
self.assertTrue(draft.name in r.content)
245+
self.assertTrue(draft.name in unicontent(r))
244246

245247
def test_csv_for_group(self):
246248
draft = make_test_data()
@@ -273,12 +275,12 @@ def test_feed(self):
273275
)
274276
r = self.client.get(url)
275277
self.assertEqual(r.status_code, 200)
276-
self.assertTrue(draft.name in r.content)
278+
self.assertTrue(draft.name in unicontent(r))
277279

278280
# only significant
279281
r = self.client.get(url + "?significant=1")
280282
self.assertEqual(r.status_code, 200)
281-
self.assertTrue('<entry>' not in r.content)
283+
self.assertTrue('<entry>' not in unicontent(r))
282284

283285
def test_feed_for_group(self):
284286
draft = make_test_data()

ietf/iesg/tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
import shutil
44
import json
55
import datetime
6+
from pyquery import PyQuery
67

78
from django.conf import settings
89
from django.urls import reverse as urlreverse
910

10-
from pyquery import PyQuery
11+
import debug # pyflakes:ignore
1112

1213
from ietf.doc.models import DocEvent, BallotDocEvent, BallotPositionDocEvent, TelechatDocEvent
1314
from ietf.doc.models import Document, DocAlias, State, RelatedDocument
@@ -449,7 +450,7 @@ def test_reschedule(self):
449450
r = self.client.get(url)
450451
self.assertEqual(r.status_code, 200)
451452
d_header_pos = r.content.find("IESG telechat %s" % d.isoformat())
452-
draft_pos = r.content[d_header_pos:].find(draft.name)
453+
draft_pos = unicontent(r)[d_header_pos:].find(draft.name)
453454
self.assertTrue(draft_pos>0)
454455

455456
self.assertTrue(draft.latest_event(TelechatDocEvent, "scheduled_for_telechat"))

0 commit comments

Comments
 (0)