@@ -344,13 +344,13 @@ def prev_state(self):
344344 def mark_by (self ):
345345 e = self .latest_event ()
346346 from person .proxy import IESGLogin as IESGLoginProxy
347- return IESGLoginProxy (e .by ) if e else None
347+ return IESGLoginProxy (). from_object ( e .by ) if e else None
348348
349349 # job_owner = models.ForeignKey(IESGLogin, db_column='job_owner', related_name='documents')
350350 @property
351351 def job_owner (self ):
352352 from person .proxy import IESGLogin as IESGLoginProxy
353- return IESGLoginProxy (self .ad ) if self .ad else None
353+ return IESGLoginProxy (). from_object ( self .ad ) if self .ad else None
354354
355355 #event_date = models.DateField(null=True)
356356 @property
@@ -441,7 +441,7 @@ def noproblem(self):
441441 def resurrect_requested_by (self ):
442442 e = self .latest_event (type__in = ("requested_resurrect" , "completed_resurrect" ))
443443 from person .proxy import IESGLogin as IESGLoginProxy
444- return IESGLoginProxy (e .by ) if e and e .type == "requested_resurrect" else None
444+ return IESGLoginProxy (). from_object ( e .by ) if e and e .type == "requested_resurrect" else None
445445
446446 #approved_in_minute = models.IntegerField(null=True, blank=True)
447447 @property
@@ -450,7 +450,7 @@ def approved_in_minute(self):
450450
451451
452452 def get_absolute_url (self ):
453- if self .rfc_flag :
453+ if self .rfc_flag and self . rfc_number :
454454 return "/doc/rfc%d/" % self .rfc_number
455455 else :
456456 return "/doc/%s/" % self .name
@@ -502,7 +502,7 @@ def an_sent_date(self):
502502 def an_sent_by (self ):
503503 e = self .latest_event (type = "iesg_approved" )
504504 from person .proxy import IESGLogin as IESGLoginProxy
505- return IESGLoginProxy (e .by ) if e else None
505+ return IESGLoginProxy (). from_object ( e .by ) if e else None
506506
507507 #defer = models.BooleanField()
508508 @property
@@ -515,7 +515,7 @@ def defer(self):
515515 def defer_by (self ):
516516 e = self .latest_event (type = "changed_document" , desc__startswith = "State changed to <b>IESG Evaluation - Defer</b>" )
517517 from person .proxy import IESGLogin as IESGLoginProxy
518- return IESGLoginProxy (e .by ) if e else None
518+ return IESGLoginProxy (). from_object ( e .by ) if e else None
519519
520520 #defer_date = models.DateField(null=True, blank=True)
521521 @property
@@ -556,7 +556,7 @@ def active_positions(self):
556556 res = []
557557 def add (ad , pos ):
558558 from person .proxy import IESGLogin as IESGLoginProxy
559- res .append (dict (ad = IESGLoginProxy (ad ), pos = Position ().from_object (pos ) if pos else None ))
559+ res .append (dict (ad = IESGLoginProxy (). from_object ( ad ), pos = Position ().from_object (pos ) if pos else None ))
560560
561561 found = set ()
562562 for pos in BallotPositionEvent .objects .filter (doc = self , type = "changed_ballot_position" , ad__in = active_ads ).select_related ('ad' ).order_by ("-time" , "-id" ):
0 commit comments