Skip to content

Commit 68ea11a

Browse files
author
Sasha Romijn
committed
Fix ietf-tools#2478 - When completing review, show which addresses it is posted to.
Commit ready for merge. - Legacy-Id: 16688
1 parent 1390ae0 commit 68ea11a

3 files changed

Lines changed: 8 additions & 0 deletions

File tree

ietf/doc/tests_review.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,9 @@ def test_complete_review_upload_content(self):
610610
# get
611611
r = self.client.get(url)
612612
self.assertEqual(r.status_code, 200)
613+
self.assertContains(r, assignment.review_request.team.list_email)
614+
for author in assignment.review_request.doc.authors():
615+
self.assertContains(r, author.formatted_email())
613616

614617
# faulty post
615618
r = self.client.post(url, data={

ietf/doc/views_review.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -786,6 +786,8 @@ def complete_review(request, name, assignment_id):
786786
'form': form,
787787
'mail_archive_query_urls': mail_archive_query_urls,
788788
'revising_review': revising_review,
789+
'review_to': to,
790+
'review_cc': cc,
789791
})
790792

791793
def search_mail_archive(request, name, assignment_id):

ietf/templates/doc/review/complete_review.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ <h1>{% if revising_review %}Revise{% else %}Complete{% endif %} review<br>
2727
system will post the review for you. If you already have posted
2828
the review, you can try to let the system find the link to the
2929
archive and retrieve the email body.</p>
30+
<p>If you enter the review below, the review will be sent
31+
to <em>{{ review_to|join:", " }}</em>
32+
{% if review_cc %}, with a Cc to <em>{{ review_cc|join:", " }}</em>{% endif %}.</p>
3033
{% else %}
3134
<p>You can revise this review by entering the results below.</p>
3235
{% endif %}

0 commit comments

Comments
 (0)