Skip to content

Commit 6622e42

Browse files
committed
Merged in [18718] from rjsparks@nostrum.com:
Allow program leads to request meetings. Fixes ietf-tools#3141. - Legacy-Id: 18734 Note: SVN reference [18718] has been migrated to Git commit 6437493
2 parents 726a7a3 + 6437493 commit 6622e42

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

ietf/group/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ def meetings(request, acronym=None, group_type=None):
767767

768768
future, in_progress, recent, past = group_sessions(sessions)
769769

770-
can_edit = group.has_role(request.user,["Chair","Secretary"])
770+
can_edit = group.has_role(request.user,group.features.groupman_roles)
771771
can_always_edit = has_role(request.user,["Secretariat","Area Director"])
772772

773773
return render(request,'group/meetings.html',

ietf/secr/utils/decorators.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from ietf.ietfauth.utils import has_role
1212
from ietf.doc.models import Document
13-
from ietf.group.models import Group, Role
13+
from ietf.group.models import Group
1414
from ietf.meeting.models import Session
1515
from ietf.secr.utils.meeting import get_timeslot
1616
from ietf.utils.response import permission_denied
@@ -65,11 +65,9 @@ def wrapper(request, *args, **kwargs):
6565
except ObjectDoesNotExist:
6666
permission_denied(request, "User not authorized to access group: %s" % group.acronym)
6767

68-
groups = [group]
69-
if group.parent:
70-
groups.append(group.parent)
71-
all_roles = Role.objects.filter(group__in=groups,name__in=('ad','chair','secr'))
72-
if login in [ r.person for r in all_roles ]:
68+
if login.role_set.filter(name__in=group.features.groupman_roles,group=group):
69+
return func(request, *args, **kwargs)
70+
elif group.parent and login.role_set.filter(name__in=group.parent.features.groupman_roles,group=group.parent):
7371
return func(request, *args, **kwargs)
7472

7573
# if session is plenary allow ietf/iab chairs

0 commit comments

Comments
 (0)