Skip to content

Commit 60b126b

Browse files
committed
Merged in [9779] from lars@netapp.com:
Remove the code that used to calculate table_rows, now that the HTML doesn't use it anymore. - Legacy-Id: 9795 Note: SVN reference [9779] has been migrated to Git commit ee1ea03
1 parent f56eec6 commit 60b126b

2 files changed

Lines changed: 0 additions & 35 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -348,22 +348,6 @@ def document_main(request, name, rev=None):
348348
published = doc.latest_event(type="published_rfc")
349349
started_iesg_process = doc.latest_event(type="started_iesg_process")
350350

351-
# We'd like to group rows in the document information table, with a first row giving the
352-
# group label. This would be easy if all browsers supported the rowspan="0" (zero)
353-
# semantics of the html standard, but only Firefox and Opera do, so we have to count
354-
# how many entries there will be in each section here, instead. Bah!
355-
table_rows = dict(doc=4, stream=2, iesg=4, iana=2, rfced=1)
356-
table_rows['doc'] += 1 if replaces or can_edit_stream_info else 0
357-
table_rows['doc'] += 1 if replaced_by else 0
358-
table_rows['doc'] += 1 if doc.get_state_slug() != "rfc" else 0
359-
table_rows['doc'] += 1 if conflict_reviews else 0
360-
361-
table_rows['stream'] += 1 if consensus else 0
362-
table_rows['stream'] += 1 if shepherd_writeup or can_edit_shepherd_writeup else 0
363-
table_rows['stream'] += 1 if published and started_iesg_process and published.time < started_iesg_process.time else 0
364-
365-
table_rows['iesg'] += 1 if iesg_state and (doc.note or can_edit) else 0
366-
367351
return render_to_response("doc/document_draft.html",
368352
dict(doc=doc,
369353
group=group,
@@ -375,9 +359,6 @@ def document_main(request, name, rev=None):
375359
snapshot=snapshot,
376360
latest_revision=latest_revision,
377361
latest_rev=latest_rev,
378-
379-
table_rows=table_rows,
380-
381362
can_edit=can_edit,
382363
can_change_stream=can_change_stream,
383364
can_edit_stream_info=can_edit_stream_info,
@@ -447,8 +428,6 @@ def document_main(request, name, rev=None):
447428

448429
can_manage = can_manage_group_type(request.user, doc.group.type_id)
449430

450-
table_rows = dict(doc=5, wg=2, iesg=3)
451-
452431
return render_to_response("doc/document_charter.html",
453432
dict(doc=doc,
454433
top=top,
@@ -463,7 +442,6 @@ def document_main(request, name, rev=None):
463442
group=group,
464443
milestones=milestones,
465444
can_manage=can_manage,
466-
table_rows=table_rows,
467445
),
468446
context_instance=RequestContext(request))
469447

@@ -481,9 +459,6 @@ def document_main(request, name, rev=None):
481459
if doc.get_state_slug() in ("iesgeval") and doc.active_ballot():
482460
ballot_summary = needed_ballot_positions(doc, doc.active_ballot().active_ad_positions().values())
483461

484-
table_rows = dict(doc=4, wg=2, iesg=3)
485-
table_rows['iesg'] += 1 if not snapshot else 0
486-
487462
return render_to_response("doc/document_conflict_review.html",
488463
dict(doc=doc,
489464
top=top,
@@ -495,7 +470,6 @@ def document_main(request, name, rev=None):
495470
conflictdoc=conflictdoc,
496471
ballot_summary=ballot_summary,
497472
approved_states=('appr-reqnopub-pend','appr-reqnopub-sent','appr-noprob-pend','appr-noprob-sent'),
498-
table_rows=table_rows,
499473
),
500474
context_instance=RequestContext(request))
501475

@@ -520,9 +494,6 @@ def document_main(request, name, rev=None):
520494
else:
521495
sorted_relations=None
522496

523-
table_rows = dict(doc=5, wg=2, iesg=3)
524-
table_rows['iesg'] += sorted_relations.count() if sorted_relations else 0
525-
526497
return render_to_response("doc/document_status_change.html",
527498
dict(doc=doc,
528499
top=top,
@@ -534,7 +505,6 @@ def document_main(request, name, rev=None):
534505
ballot_summary=ballot_summary,
535506
approved_states=('appr-pend','appr-sent'),
536507
sorted_relations=sorted_relations,
537-
table_rows=table_rows,
538508
),
539509
context_instance=RequestContext(request))
540510

ietf/group/info.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -430,17 +430,12 @@ def group_about(request, acronym, group_type=None):
430430

431431
can_manage = can_manage_group_type(request.user, group.type_id)
432432

433-
table_rows = dict(group=5, personnel=0, )
434-
table_rows["group"] += 1 if group.groupurl_set.count() else 0
435-
table_rows["personnel"] += len(group.personnel)
436-
437433
return render(request, 'group/group_about.html',
438434
construct_group_menu_context(request, group, "charter" if group.features.has_chartering_process else "about", group_type, {
439435
"milestones_in_review": group.groupmilestone_set.filter(state="review"),
440436
"milestone_reviewer": milestone_reviewer_for_group_type(group_type),
441437
"requested_close": requested_close,
442438
"can_manage": can_manage,
443-
"table_rows": table_rows,
444439
}))
445440

446441

0 commit comments

Comments
 (0)