Skip to content

Commit 5e6ecfb

Browse files
committed
Refined the appearance and wording of the 'Manage document's adoption' button.
- Legacy-Id: 13680
1 parent e4fc7f0 commit 5e6ecfb

3 files changed

Lines changed: 44 additions & 2 deletions

File tree

changelog

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,40 @@
1+
ietfdb (6.55.1) ietf; urgency=medium
2+
3+
This is a bugfix release, with some smaller enhancements. From the commit
4+
log:
5+
6+
* Don't deliver spurious yang extraction errors for drafts where no yang
7+
modules were found.
8+
9+
* Replaced the use of unaccent.asciify(), which has similar functionality
10+
as unidecode.unidecode(). Changed the draft parser to work exclusively
11+
with unicode text, which both makes the removal of unaccent easier, and
12+
takes us closer to Py35 compatibility. Adjusted callers of the draft
13+
parser to send in unicode.
14+
15+
* Removed code which has been marked as unreachable since February/March
16+
2017 and has not triggering any usage indications.
17+
18+
* Changed the display of people with roles on the various group pages to
19+
link to both their profile page and their email address.
20+
21+
* Improved the handling of surname particles, (prompted by failure to
22+
handle the name of Niels ten Oever correctly).
23+
24+
* Made changes to the can_adopt_draft() logic, to make it possible for a
25+
chair of multiple groups to correct the mistake if adoption was made for
26+
the wrong group.
27+
28+
* Merged in [13615] and [13627]from rcross@amsl.com:
29+
Changed views that use GET requests to delete objects to use POST.
30+
Fixes #1796.
31+
32+
* Make sure wordwrap() and friend works as intended if they are used as
33+
template filters and given string arguments.
34+
35+
-- Henrik Levkowetz <henrik@levkowetz.com> 17 Jun 2017 14:16:17 -0700
36+
37+
138
ietfdb (6.55.0) ietf; urgency=medium
239

340
**Improved Yang validation support**

ietf/doc/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def can_adopt_draft(user, doc):
113113
role_groups = [ r.group for r in roles ]
114114

115115
return (doc.stream_id in (None, "ietf", "irtf")
116-
and (doc.group.type_id == "individ" or doc.group in role_groups)
116+
and (doc.group.type_id == "individ" or (doc.group in role_groups and len(role_groups)>1))
117117
and roles.exists())
118118

119119
def two_thirds_rule( recused=0 ):

ietf/doc/views_doc.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,12 @@ def document_main(request, name, rev=None):
321321
actions = []
322322

323323
if can_adopt_draft(request.user, doc) and not doc.get_state_slug() in ["rfc"] and not snapshot:
324-
actions.append(("Manage Document Adoption in Group", urlreverse('ietf.doc.views_draft.adopt_draft', kwargs=dict(name=doc.name))))
324+
if doc.group:
325+
# already adopted in one group
326+
button_text = "Change Document Adoption to other Group"
327+
else:
328+
button_text = "Manage Document Adoption in Group"
329+
actions.append((button_text, urlreverse('ietf.doc.views_draft.adopt_draft', kwargs=dict(name=doc.name))))
325330

326331
if doc.get_state_slug() == "expired" and not resurrected_by and can_edit and not snapshot:
327332
actions.append(("Request Resurrect", urlreverse('ietf.doc.views_draft.request_resurrect', kwargs=dict(name=doc.name))))

0 commit comments

Comments
 (0)