Skip to content

Commit 5bbbe24

Browse files
committed
Made ietf/secr/announcement pyflakes-clean.
- Legacy-Id: 7481
1 parent 8a6c121 commit 5bbbe24

5 files changed

Lines changed: 16 additions & 27 deletions

File tree

ietf/secr/announcement/forms.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
from django import forms
22
from django.core.validators import validate_email
33

4-
from models import *
5-
from ietf.secr.utils.mail import MultiEmailField
6-
from ietf.secr.utils.group import current_nomcom
7-
8-
from ietf.message.models import Message
4+
from ietf.group.models import Group, Role
95
from ietf.ietfauth.utils import has_role
6+
from ietf.message.models import Message
7+
from ietf.secr.utils.group import current_nomcom
108

119
# ---------------------------------------------
1210
# Globals

ietf/secr/announcement/models.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
from django.db import models
2-
#from ietf.message.models import Message
3-
from ietf.group.models import Group, Role

ietf/secr/announcement/tests.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
from django.db import connection
22
from django.core.urlresolvers import reverse
3-
from ietf.utils import TestCase
4-
from django.contrib.auth.models import User
53

6-
from ietf.group.models import Group
7-
from ietf.ietfauth.utils import has_role
4+
from pyquery import PyQuery
5+
6+
from ietf.utils import TestCase
87
from ietf.person.models import Person
9-
from ietf.utils.mail import outbox
108
from ietf.utils.test_data import make_test_data
119

12-
from pyquery import PyQuery
1310

1411
SECR_USER='secretary'
1512
WG_USER=''
@@ -19,7 +16,7 @@ class MainTestCase(TestCase):
1916
# ------- Test View -------- #
2017
def test_main(self):
2118
"Main Test"
22-
draft = make_test_data()
19+
make_test_data()
2320
url = reverse('announcement')
2421
r = self.client.get(url, REMOTE_USER=SECR_USER)
2522
self.assertEqual(r.status_code, 200)
@@ -30,7 +27,7 @@ class DummyCase(TestCase):
3027
class UnauthorizedCase(TestCase):
3128
def test_unauthorized(self):
3229
"Unauthorized Test"
33-
draft = make_test_data()
30+
make_test_data()
3431
url = reverse('announcement')
3532
person = Person.objects.filter(role__group__acronym='mars')[0]
3633
r = self.client.get(url,REMOTE_USER=person.user)
@@ -39,7 +36,7 @@ def test_unauthorized(self):
3936
class SubmitCase(TestCase):
4037
def test_invalid_submit(self):
4138
"Invalid Submit"
42-
draft = make_test_data()
39+
make_test_data()
4340
url = reverse('announcement')
4441
post_data = {'id_subject':''}
4542
#self.client.login(remote_user='rcross')
@@ -50,7 +47,7 @@ def test_invalid_submit(self):
5047

5148
def test_valid_submit(self):
5249
"Valid Submit"
53-
draft = make_test_data()
50+
make_test_data()
5451
#ietf.utils.mail.test_mode = True
5552
url = reverse('announcement')
5653
redirect = reverse('announcement_confirm')

ietf/secr/announcement/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls import *
1+
from django.conf.urls import patterns, url
22

33
urlpatterns = patterns('ietf.secr.announcement.views',
44
url(r'^$', 'main', name='announcement'),

ietf/secr/announcement/views.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
11
from django.contrib import messages
2-
from django.core.urlresolvers import reverse
3-
from django.http import HttpResponse, HttpResponseForbidden
4-
from django.shortcuts import render_to_response, get_object_or_404, redirect
2+
from django.http import HttpResponseForbidden
3+
from django.shortcuts import render_to_response, redirect
54
from django.template import RequestContext
65

6+
from ietf.group.models import Role
77
from ietf.ietfauth.utils import has_role
8-
from ietf.utils.mail import send_mail_text
9-
from ietf.group.models import Group
10-
from ietf.secr.utils.group import current_nomcom
8+
from ietf.secr.announcement.forms import AnnounceForm
119
from ietf.secr.utils.decorators import check_for_cancel
12-
13-
from forms import *
10+
from ietf.utils.mail import send_mail_text
1411

1512
# -------------------------------------------------
1613
# Helper Functions

0 commit comments

Comments
 (0)