Skip to content

Commit 5abcec4

Browse files
committed
Added a bit of name normalization for test factory person names.
- Legacy-Id: 15888
1 parent 97db43d commit 5abcec4

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

ietf/person/factories.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import debug # pyflakes:ignore
1818

1919
from ietf.person.models import Person, Alias, Email
20-
from ietf.person.name import unidecode_name
20+
from ietf.person.name import normalize_name, unidecode_name
2121

2222

2323
fake = faker.Factory.create()
@@ -53,7 +53,7 @@ class Meta:
5353
model = Person
5454

5555
user = factory.SubFactory(UserFactory)
56-
name = factory.LazyAttribute(lambda p: u'%s %s'%(p.user.first_name,p.user.last_name))
56+
name = factory.LazyAttribute(lambda p: normalize_name(u'%s %s'%(p.user.first_name, p.user.last_name)))
5757
ascii = factory.LazyAttribute(lambda p: unicode(unidecode_name(p.name)))
5858

5959
class Params:

ietf/person/name.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,12 @@ def unidecode_name(uname):
119119
name = re.sub(' +', ' ', name)
120120
return name
121121

122+
def normalize_name(s):
123+
# There is probably more to be done here, but we start by normalising
124+
# spaces:
125+
s = re.sub(' +', ' ', s)
126+
return s
127+
122128
if __name__ == "__main__":
123129
import sys
124130
name = u" ".join(sys.argv[1:])

0 commit comments

Comments
 (0)