Skip to content

Commit 5a87898

Browse files
committed
Guard against reviewer name not being filled in properly (still
containing a @) on the complete review page - Legacy-Id: 12127
1 parent 336e2bb commit 5a87898

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

ietf/doc/views_review.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,9 @@ def clean_review_file(self):
367367
return get_cleaned_text_file_content(self.cleaned_data["review_file"])
368368

369369
def clean(self):
370+
if "@" in self.review_req.reviewer.person.ascii:
371+
raise forms.ValidationError("Reviewer name must be filled in (the ASCII version is currently \"{}\" - since it contains an @ sign the name is probably still the original email address).".format(self.review_req.reviewer.person.ascii))
372+
370373
def require_field(f):
371374
if not self.cleaned_data.get(f):
372375
self.add_error(f, ValidationError("You must fill in this field."))

0 commit comments

Comments
 (0)