Skip to content

Commit 58f50b7

Browse files
committed
Don't overwrite possible manual changes to existing name table entries when using name() to create/fetch name entries.
- Legacy-Id: 4161
1 parent 6eb2e7c commit 58f50b7

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

ietf/name/utils.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
def name(name_class, slug, name, desc="", order=0, **kwargs):
22
# create if it doesn't exist, set name and desc
3-
obj, _ = name_class.objects.get_or_create(slug=slug)
4-
obj.name = name
5-
obj.desc = desc
6-
obj.order = order
7-
for k, v in kwargs.iteritems():
8-
setattr(obj, k, v)
9-
obj.save()
3+
obj, created = name_class.objects.get_or_create(slug=slug)
4+
if created:
5+
obj.name = name
6+
obj.desc = desc
7+
obj.order = order
8+
for k, v in kwargs.iteritems():
9+
setattr(obj, k, v)
10+
obj.save()
1011
return obj

0 commit comments

Comments
 (0)