Skip to content

Commit 5742a98

Browse files
committed
Merged in [19136] from jennifer@painless-security.com:
More prominently identify BoF sessions in schedule editor. Fixes ietf-tools#3217. - Legacy-Id: 19145 Note: SVN reference [19136] has been migrated to Git commit 7c09aec
2 parents cfbd63d + 7c09aec commit 5742a98

3 files changed

Lines changed: 34 additions & 2 deletions

File tree

ietf/meeting/tests_views.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -970,6 +970,30 @@ def test_room_grouping(self):
970970
time_labels = row.find('div.time-label').text()
971971
self.assertEqual(time_labels, time_header_labels)
972972

973+
def test_bof_session_tag(self):
974+
"""Sessions for BoF groups should be marked as such"""
975+
meeting = MeetingFactory(type_id='ietf')
976+
977+
non_bof_session = SessionFactory(meeting=meeting)
978+
bof_session = SessionFactory(meeting=meeting, group__state_id='bof')
979+
980+
url = urlreverse('ietf.meeting.views.edit_meeting_schedule',
981+
kwargs=dict(num=meeting.number))
982+
983+
self.client.login(username='secretary', password='secretary+password')
984+
r = self.client.get(url)
985+
self.assertEqual(r.status_code, 200)
986+
987+
q = PyQuery(r.content)
988+
self.assertEqual(len(q('#session{} .bof-tag'.format(non_bof_session.pk))), 0,
989+
'Non-BoF session should not be tagged as a BoF session')
990+
991+
bof_tags = q('#session{} .bof-tag'.format(bof_session.pk))
992+
self.assertEqual(len(bof_tags), 1,
993+
'BoF session should have one BoF session tag')
994+
self.assertIn('BoF', bof_tags.eq(0).text(),
995+
'BoF tag should contain text "BoF"')
996+
973997

974998
class ReorderSlidesTests(TestCase):
975999

ietf/static/ietf/css/ietf.css

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,10 +1169,12 @@ a.fc-event, .fc-event, .fc-content, .fc-title, .fc-event-container {
11691169
.edit-meeting-schedule .session.selected {
11701170
cursor: grabbing;
11711171
outline: #0000ff solid 0.2em; /* blue, width matches margin on .session */
1172+
z-index: 2; /* render above timeslot outlines */
11721173
}
11731174

11741175
.edit-meeting-schedule .session.other-session-selected {
11751176
outline: #00008b solid 0.2em; /* darkblue, width matches margin on .session */
1177+
z-index: 2; /* render above timeslot outlines */
11761178
}
11771179

11781180
.edit-meeting-schedule .read-only .session.selected {
@@ -1228,8 +1230,13 @@ a.fc-event, .fc-event, .fc-content, .fc-title, .fc-event-container {
12281230
margin-left: 0.1em;
12291231
}
12301232

1231-
.edit-meeting-schedule .session .session-label.bof-session {
1232-
font-style: italic;
1233+
.edit-meeting-schedule .session .session-label .bof-tag {
1234+
font-style: normal;
1235+
font-size: smaller;
1236+
color: #8b0000;
1237+
font-weight: bold;
1238+
float: right;
1239+
margin-right: 0.2em;
12331240
}
12341241

12351242
.edit-meeting-schedule .session.too-many-attendees .attendees {

ietf/templates/meeting/edit_meeting_schedule_session.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<div id="session{{ session.pk }}" class="session {% if not session.group.parent.scheduling_color %}untoggleable{% endif %} {% if session.parent_acronym %}parent-{{ session.parent_acronym }}{% endif %} {% if session.readonly %}readonly{% endif %}" style="width:{{ session.layout_width }}em;" data-duration="{{ session.requested_duration.total_seconds }}" {% if session.attendees != None %}data-attendees="{{ session.attendees }}"{% endif %}>
22
<div class="session-label {% if session.group and session.group.is_bof %}bof-session{% endif %}">
33
{{ session.scheduling_label }}
4+
{% if session.group and session.group.is_bof %}<span class="bof-tag">BoF</span>{% endif %}
45
</div>
56

67
<div>

0 commit comments

Comments
 (0)