Skip to content

Commit 56f9260

Browse files
committed
Show out-of-area ads on /wg/. Fixes ietf-tools#1555. Related to ietf-tools#1557. Commit ready for merge.
- Legacy-Id: 8856
1 parent 65804be commit 56f9260

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

ietf/group/info.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ def active_wgs(request):
205205
area.urls = area.groupurl_set.all().order_by("name")
206206
for group in area.groups:
207207
group.chairs = sorted(roles(group, "chair"), key=extract_last_name)
208+
group.ad_out_of_area = group.ad_role().person not in [role.person for role in area.ads]
208209
# get the url for mailing list subscription
209210
if group.list_subscribe.startswith('http'):
210211
group.list_subscribe_url = group.list_subscribe

ietf/templates/group/active_wgs.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
{% block title %}Active IETF Working Groups{% endblock %}
3838

3939
{% block morecss %}
40-
.ietf-wg-table { width: 100%; max-width:70em; }
40+
.ietf-wg-table { width: 100%; max-width:80em; }
4141
.ietf-wg-table tr { vertical-align:top; }
4242
{% endblock morecss %}
4343

@@ -80,12 +80,12 @@ <h2 class="ietf-divider" id="{{area.name|cut:" "}}">{{ area.name }}</h2>
8080
<table class="ietf-wg-table">
8181
{% for group in area.groups %}
8282
<tr>
83-
<td width="8%;"><a href="{% url "ietf.group.info.group_home" group_type=group.type_id acronym=group.acronym %}">{{ group.acronym }}</a></td>
84-
<td width="1%">{% for ad in area.ads %}{% if ad.person_id == group.ad_role.person.id %}<span title="AD for {{ group.acronym }}: {{ ad.person }}" class="square bgcolor{{forloop.counter}}"></span>{% endif %}{% endfor %}</td>
85-
<td width="35%">{{ group.name }}</td>
86-
<td width="15%"><a href="{{ group.list_archive }}"><span title="Click to view list archive">{{ group.list_email }}</span></a></td>
87-
<td width="8%"><a href="{{ group.list_subscribe_url }}">subscribe</a></td>
88-
<td width="33%">{% for chair in group.chairs %}<a href="mailto:{{ chair.email.address }}">{{ chair.person.plain_name }}</a>{% if not forloop.last %}, {% endif %}{% endfor %}</td>
83+
<td width="7%;"><a href="{% url "ietf.group.info.group_home" group_type=group.type_id acronym=group.acronym %}">{{ group.acronym }}</a></td>
84+
<td width="1%"><span title="AD for {{ group.acronym }}: {{ group.ad_role.person }}" class="square {% if group.ad_out_of_area %}bgcolor3{% else %}{% for ad in area.ads %}{% if ad.person_id == group.ad_role.person.id %}bgcolor{{forloop.counter}}{% endif %}{% endfor %}{% endif %} "></span></td>
85+
<td width="31%">{{ group.name }}</td>
86+
<td width="13%"><a href="{{ group.list_archive }}"><span title="Click to view list archive">{{ group.list_email }}</span></a></td>
87+
<td width="7%"><a href="{{ group.list_subscribe_url }}">subscribe</a></td>
88+
<td width="41%">{% for chair in group.chairs %}<a href="mailto:{{ chair.email.address }}">{{ chair.person.plain_name }}</a>{% if not forloop.last %}, {% endif %}{% endfor %}{% if group.ad_out_of_area %} (Assigned AD: <a href="mailto:{{ group.ad_role.email.address }}">{{ group.ad_role.person.plain_name }}</a>){%endif%}</td>
8989
</tr>
9090
{% endfor %}
9191
</table>

static/css/base2.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ form table .help, form table .helptext {
188188
.color2 { color: #00ffff; }
189189
.bgcolor1 { background-color: #ffb000; }
190190
.bgcolor2 { background-color: #00ffff; }
191+
.bgcolor3 { background-color: #f00000; }
191192
.square { width: 0.8ex; height: 0.8ex; margin: 0; padding: 0; display: inline-block; position: relative; top: 0.8ex; }
192193
.big { font-size: 109.5%; margin: 0; padding: 0; }
193194
.large { font-size: 120%; margin: 0; padding: 0; }

0 commit comments

Comments
 (0)