Skip to content

Commit 5382b31

Browse files
committed
Fix problem with incomplete proxying in IESG scribe template, found by
John Leslie - Legacy-Id: 3925
1 parent 29366bf commit 5382b31

3 files changed

Lines changed: 31 additions & 2 deletions

File tree

ietf/doc/proxy.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,8 @@ def from_object(self, base):
819819
for f in base._meta.fields:
820820
if not f.name in ('discuss',): # don't overwrite properties
821821
setattr(self, f.name, getattr(base, f.name))
822+
823+
self.orig = base
822824
return self
823825

824826
#ballot = models.ForeignKey(BallotInfo, related_name='positions')

ietf/templates/iesg/scribe_doc.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
{% if USE_DB_REDESIGN_PROXY_CLASSES %}
5252
{% for p in doc.obj.active_positions|dictsort:"ad.plain_name" %}{% if p.pos %}{% ifequal p.pos.pos_id "discuss" %}<li><a href="#{{doc.obj.document.filename}}+{{p.pos.ad|slugify}}+discuss">{{ p.pos.ad.plain_name }}: Discuss [{{ p.pos.discuss_time.date }}]</a>:
5353
<br>...
54-
{% endifequal %}{% if p.pos.comment %} <li><a href="#{{doc.obj.document.filename}}+{{position.ad|slugify}}+comment">{{ p.pos.ad.plain_name }}: Comment [{{ p.pos.comment_time.date }}]</a>:
54+
{% endifequal %}{% if p.pos.comment %} <li><a href="#{{doc.obj.document.filename}}+{{p.ad.plain_name|slugify}}+comment">{{ p.pos.ad.plain_name }}: Comment [{{ p.pos.comment_time.date }}]</a>:
5555
<br>...
5656
{% endif %}{% endif %}{% endfor %}
5757
{% else %}

ietf/templates/iesg/scribe_doc2.html

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,37 @@
3838
<p><b>{{ doc.obj.document.filename }}</b></p>
3939
{% if doc.obj.ballot.active %}
4040
<ol>
41+
{% if USE_DB_REDESIGN_PROXY_CLASSES %}
42+
43+
{% for p in doc.obj.active_positions|dictsort:"ad.plain_name" %}
44+
45+
{% if p.pos and p.pos.pos_id == "discuss" %}
46+
<li><a name="{{doc.obj.document.filename}}+{{p.ad.plain_name|slugify}}+discuss">{{ p.ad.plain_name }}</a>: Discuss [{{ p.pos.discuss_time|date:"Y-m-d" }}]:<br>
47+
<pre>
48+
{{ p.pos.orig.discuss|fill:"80"|escape }}
49+
</pre>
50+
</li>
51+
{% endif %}
52+
53+
{% if p.pos and p.pos.comment %}
54+
<li><a name="{{doc.obj.document.filename}}+{{p.ad.plain_name|slugify}}+comment">{{ p.ad.plain_name }}</a>: Comment [{{ p.pos.comment_time|date:"Y-m-d" }}]:<br>
55+
<pre>{{ p.pos.comment|fill:"80"|escape }}</pre>
56+
</li>
57+
{% endif %}
58+
{% endfor %}
59+
60+
{% else %}
61+
4162
{% for position in doc.obj.ballot.positions.all|dictsort:"ad.last_name" %}{% ifequal position.discuss 1 %} <li><a name="{{doc.obj.document.filename}}+{{position.ad|slugify}}+discuss">{{ position.ad }}</a>:{% for item in doc.obj.ballot.discusses.all %}{% ifequal position.ad item.ad %} Discuss [{{ item.date }}]:<br>
4263
<pre>
4364
{{ item.text|fill:"80"|escape }}
4465
</pre>
4566
{% endifequal %}{% endfor %}{% endifequal %}{% for item in doc.obj.ballot.comments.all %}{% ifequal position.ad item.ad %} <li><a name="{{doc.obj.document.filename}}+{{position.ad|slugify}}+comment">{{ position.ad }}</a>: Comment [{{ item.date }}]:<br>
4667
<pre>{{ item.text|fill:"80"|escape }}</pre>
47-
{% endifequal %}{% endfor %}{% endfor %} </ol>{%endif %}
68+
{% endifequal %}{% endfor %}{% endfor %}
69+
70+
{%endif %}
71+
72+
</ol>
73+
74+
{% endif%}

0 commit comments

Comments
 (0)