Skip to content

Commit 52a0825

Browse files
committed
Take advantage of new include tag that can combine the include with a
"with foo=bar" instead of having separate "with" tags - Legacy-Id: 6962
1 parent 36dd439 commit 52a0825

4 files changed

Lines changed: 4 additions & 8 deletions

File tree

ietf/templates/iesg/milestones_needing_review.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ <h3 class="ad">{{ ad.plain_name }}</h4>
1717

1818
<div class="milestones-for-group">{{ g.name }} ({{ g.acronym }}) <a href="{% url "wg_edit_milestones" acronym=g.acronym %}">has new milestones</a>:</div>
1919

20-
{% with g.milestones_needing_review as milestones %}
21-
{% include "wginfo/milestones.html" %}
22-
{% endwith %}
20+
{% include "wginfo/milestones.html" with milestones=g.milestones_needing_review %}
2321

2422
{% endfor %}
2523
{% endfor %}

ietf/templates/wginfo/edit_milestones.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ <h1>{{ title }}</h1>
8787
<tr class="edit-milestone{% if form.changed %} changed{% endif %}"><td colspan="2">{% include "wginfo/milestone_form.html" %}</td></tr>
8888
{% endfor %}
8989
<tr class="milestone add"><td></td><td>Add {% if milestone_set == "chartering" %}charter{% endif%} milestone {% if needs_review %}for AD review{% endif %}</td></tr>
90-
<tr class="edit-milestone template"><td colspan="2">{% with empty_form as form %}{% include "wginfo/milestone_form.html" %}{% endwith %}</td></tr>
90+
<tr class="edit-milestone template"><td colspan="2">{% include "wginfo/milestone_form.html" with form=empty_form %}</td></tr>
9191
</table>
9292

9393
<div class="actions">

ietf/templates/wginfo/group_charter.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,7 @@ <h2>Charter for {% if group.state_id == "proposed" %}Proposed{% endif %} Working
156156

157157
<h2>{% if group.state_id == "proposed" %}Proposed{% endif %} Milestones</h2>
158158

159-
{% with group.milestones as milestones %}
160-
{% include "wginfo/milestones.html" %}
161-
{% endwith %}
159+
{% include "wginfo/milestones.html" with milestones=group.milestones %}
162160

163161
{% if milestones_in_review %}
164162
<p>+ {{ milestones_in_review|length }} new milestone{{ milestones_in_review|pluralize }}

ietf/templates/wginfo/group_documents.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
{% include "doc/search/search_results.html" %}
99

10-
{% with docs_related as docs %}{% with meta_related as meta %}{% include "doc/search/search_results.html" %}{% endwith %}{% endwith %}
10+
{% include "doc/search/search_results.html" with docs=docs_related meta=meta_related %}
1111

1212
</div>
1313
{% endblock group_content %}

0 commit comments

Comments
 (0)