Skip to content

Commit 5089651

Browse files
committed
Don't use EmptyQuerySet directly; return Class.objects.none() instead.
- Legacy-Id: 12013
1 parent d0c3331 commit 5089651

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

ietf/doc/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import json
88

99
from django.conf import settings
10-
from django.db.models.query import EmptyQuerySet
1110
from django.forms import ValidationError
1211
from django.utils.html import escape
1312
from django.core.urlresolvers import reverse as urlreverse
@@ -146,7 +145,7 @@ def needed_ballot_positions(doc, active_positions):
146145
elif isinstance(doc,DocHistory):
147146
related_set = doc.relateddochistory_set
148147
else:
149-
related_set = EmptyQuerySet()
148+
related_set = RelatedDocHistory.objects.none()
150149
for rel in related_set.filter(relationship__slug__in=['tops', 'tois', 'tohist', 'toinf', 'tobcp', 'toexp']):
151150
if (rel.target.document.std_level.slug in ['bcp','ps','ds','std']) or (rel.relationship.slug in ['tops','tois','tobcp']):
152151
needed = two_thirds_rule(recused=len(recuse))

ietf/doc/views_search.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
from django.core.cache import cache
3939
from django.core.urlresolvers import reverse as urlreverse
4040
from django.db.models import Q
41-
from django.db.models.query import EmptyQuerySet
4241
from django.http import Http404, HttpResponseBadRequest, HttpResponse, HttpResponseRedirect, QueryDict
4342
from django.shortcuts import render
4443
from django.utils.cache import _generate_cache_key
@@ -144,7 +143,7 @@ def retrieve_search_results(form, all_types=False):
144143
types.extend(query["doctypes"])
145144

146145
if not types:
147-
return EmptyQuerySet()
146+
return Document.objects.none()
148147

149148
docs = Document.objects.filter(type__in=types)
150149

0 commit comments

Comments
 (0)