Skip to content

Commit 4dd7b69

Browse files
committed
Made ietf/secr/meetings pyflakes-clean and fixed a bug in the signature of is_combined()
- Legacy-Id: 7487
1 parent aeaf041 commit 4dd7b69

5 files changed

Lines changed: 18 additions & 21 deletions

File tree

ietf/secr/meetings/forms.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1+
import datetime
2+
import re
3+
14
from django import forms
2-
from django.db.models import Q
35

46
from ietf.group.models import Group
57
from ietf.meeting.models import Meeting, Room, TimeSlot, Session, ScheduledSession
68
from ietf.meeting.timedeltafield import TimedeltaFormField, TimedeltaWidget
79
from ietf.name.models import TimeSlotTypeName
810

9-
import datetime
10-
import itertools
11-
import re
1211

1312
DAYS_CHOICES = ((-1,'Saturday'),
1413
(0,'Sunday'),

ietf/secr/meetings/models.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from django.db import models
21
#from sec.core.models import Meeting
32
"""
43
import datetime

ietf/secr/meetings/tests.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from ietf.meeting.models import Meeting
55
from ietf.utils.test_data import make_test_data
66

7-
from pyquery import PyQuery
87

98
SECR_USER='secretary'
109

@@ -17,7 +16,7 @@ def test_main(self):
1716

1817
def test_view(self):
1918
"View Test"
20-
draft = make_test_data()
19+
make_test_data()
2120
meeting = Meeting.objects.all()[0]
2221
url = reverse('meetings_view', kwargs={'meeting_id':meeting.number})
2322
response = self.client.get(url, REMOTE_USER=SECR_USER)

ietf/secr/meetings/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls import *
1+
from django.conf.urls import patterns, url
22

33
urlpatterns = patterns('ietf.secr.meetings.views',
44
url(r'^$', 'main', name='meetings'),

ietf/secr/meetings/views.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,35 @@
1+
import os
2+
import datetime
3+
import json
4+
15
from django.conf import settings
26
from django.contrib import messages
3-
from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned
47
from django.core.urlresolvers import reverse
5-
from django.db.models import Max, Min, Q
8+
from django.db.models import Max
69
from django.forms.formsets import formset_factory
7-
from django.forms.models import inlineformset_factory, modelformset_factory
10+
from django.forms.models import inlineformset_factory
811
from django.http import HttpResponseRedirect, HttpResponse
912
from django.shortcuts import render_to_response, get_object_or_404, redirect
1013
from django.template import RequestContext
1114
from django.utils.functional import curry
1215

1316
from ietf.utils.mail import send_mail
14-
from ietf.meeting.models import Meeting, Session, Room, TimeSlot, Schedule, ScheduledSession
17+
from ietf.meeting.models import Meeting, Session, Room, TimeSlot, ScheduledSession
1518
from ietf.meeting.helpers import get_schedule
1619
from ietf.group.models import Group
17-
from ietf.name.models import SessionStatusName, TimeSlotTypeName
1820
from ietf.person.models import Person
1921
from ietf.secr.meetings.blue_sheets import create_blue_sheets
22+
from ietf.secr.meetings.forms import ( BaseMeetingRoomFormSet, ExtraSessionForm, MeetingModelForm,
23+
MeetingRoomForm, NewSessionForm, NonSessionEditForm, NonSessionForm, TimeSlotForm,
24+
UploadBlueSheetForm, get_next_slot )
2025
from ietf.secr.proceedings.views import build_choices, handle_upload_file
2126
from ietf.secr.sreq.forms import GroupSelectForm
22-
from ietf.secr.sreq.views import get_initial_session, session_conflicts_as_string
27+
from ietf.secr.sreq.views import get_initial_session
2328
from ietf.secr.utils.mail import get_cc_list
2429
from ietf.secr.utils.meeting import get_upload_root, get_session, get_timeslot
2530

26-
from forms import *
2731

28-
import os
29-
import datetime
30-
import json
32+
3133

3234
# prep for agenda changes
3335
# --------------------------------------------------
@@ -79,7 +81,6 @@ def build_timeslots(meeting,room=None):
7981
source_meeting = get_last_meeting(meeting)
8082

8183
delta = meeting.date - source_meeting.date
82-
initial = []
8384
timeslots = []
8485
time_seen = set()
8586
for t in source_meeting.timeslot_set.filter(type='session'):
@@ -133,7 +134,7 @@ def get_last_meeting(meeting):
133134
last_number = int(meeting.number) - 1
134135
return Meeting.objects.get(number=last_number)
135136

136-
def is_combined(session):
137+
def is_combined(session, meeting):
137138
'''
138139
Check to see if this session is using two combined timeslots
139140
'''
@@ -590,7 +591,6 @@ def schedule(request, meeting_id, acronym):
590591
group = get_object_or_404(Group, acronym=acronym)
591592
sessions = Session.objects.filter(meeting=meeting,group=group,status__in=('schedw','apprw','appr','sched','canceled'))
592593
legacy_session = get_initial_session(sessions)
593-
session_conflicts = session_conflicts_as_string(group, meeting)
594594
now = datetime.datetime.now()
595595

596596
# build initial

0 commit comments

Comments
 (0)