Skip to content

Commit 4a45328

Browse files
committed
Simplified meeting.session_details. Shows all sessions for a meeting on one page instead of having a page per session. Removes the by-date, by-weekday, by-sequence mechanic.
- Legacy-Id: 10701
1 parent 67f0234 commit 4a45328

4 files changed

Lines changed: 24 additions & 76 deletions

File tree

ietf/meeting/urls.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@
6161
(r'^(?P<num>\d+)/session/(?P<sessionid>\d+)/constraints.json', ajax.session_constraints),
6262

6363
(r'^(?P<num>\d+)/session/(?P<acronym>[A-Za-z0-9_\-\+]+)/$', views.session_details),
64-
(r'^(?P<num>\d+)/session/(?P<acronym>[A-Za-z0-9_\-\+]+)/(?P<seq>\d+)/$', views.session_details),
65-
(r'^(?P<num>\d+)/session/(?P<acronym>[A-Za-z0-9_\-\+]+)/(?P<week_day>[a-zA-Z]+)/$', views.session_details),
66-
(r'^(?P<num>\d+)/session/(?P<acronym>[A-Za-z0-9_\-\+]+)/(?P<date>\d{4}-\d{2}-\d{2}(-\d{4})?)/$', views.session_details),
67-
(r'^(?P<num>\d+)/session/(?P<acronym>[A-Za-z0-9_\-\+]+)/(?P<date>\d{4}-\d{2}-\d{2}(-\d{4})?)/(?P<seq>\d+)/$', views.session_details),
6864

6965
(r'^(?P<num>\d+)/constraint/(?P<constraintid>\d+).json', ajax.constraint_json),
7066
(r'^(?P<num>\d+).json$', ajax.meeting_json),

ietf/meeting/views.py

Lines changed: 12 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -824,30 +824,13 @@ def meeting_requests(request, num=None):
824824
{"meeting": meeting, "sessions":sessions,
825825
"groups_not_meeting": groups_not_meeting})
826826

827-
def session_details(request, num, acronym, date=None, week_day=None, seq=None):
827+
def session_details(request, num, acronym ):
828828
meeting = get_meeting(num)
829829
sessions = Session.objects.filter(meeting=meeting,group__acronym=acronym,type__in=['session','plenary','other'])
830830

831831
if not sessions:
832832
sessions = Session.objects.filter(meeting=meeting,short=acronym)
833833

834-
if date:
835-
if len(date)==15:
836-
start = datetime.datetime.strptime(date,"%Y-%m-%d-%H%M")
837-
sessions = sessions.filter(timeslotassignments__schedule=meeting.agenda,timeslotassignments__timeslot__time=start)
838-
else:
839-
start = datetime.datetime.strptime(date,"%Y-%m-%d").date()
840-
end = start+datetime.timedelta(days=1)
841-
sessions = sessions.filter(timeslotassignments__schedule=meeting.agenda,timeslotassignments__timeslot__time__range=(start,end))
842-
843-
if week_day:
844-
try:
845-
dow = ['sun','mon','tue','wed','thu','fri','sat'].index(week_day.lower()[:3]) + 1
846-
except ValueError:
847-
raise Http404
848-
sessions = sessions.filter(timeslotassignments__schedule=meeting.agenda,timeslotassignments__timeslot__time__week_day=dow)
849-
850-
851834
def sort_key(session):
852835
official_sessions = session.timeslotassignments.filter(schedule=session.meeting.agenda)
853836
if official_sessions:
@@ -857,34 +840,19 @@ def sort_key(session):
857840

858841
sessions = sorted(sessions,key=sort_key)
859842

860-
if seq:
861-
iseq = int(seq) - 1
862-
if not iseq in range(0,len(sessions)):
863-
raise Http404
864-
else:
865-
sessions= [sessions[iseq]]
866-
867843
if not sessions:
868844
raise Http404
869845

870-
if len(sessions)==1:
871-
session = sessions[0]
872-
scheduled_time = "Not yet scheduled"
846+
for session in sessions:
847+
873848
ss = session.timeslotassignments.filter(schedule=meeting.agenda).order_by('timeslot__time')
874-
if ss:
875-
scheduled_time = ','.join(x.timeslot.time.strftime("%A %b-%d %H%M") for x in ss)
849+
session.time = ', '.join(x.timeslot.time.strftime("%A %b-%d %H%M") for x in ss) if ss else 'Not yet scheduled'
850+
876851
# TODO FIXME Deleted materials shouldn't be in the sessionpresentation_set
877-
filtered_sessionpresentation_set = [p for p in session.sessionpresentation_set.all() if p.document.get_state_slug(p.document.type_id)!='deleted']
878-
return render(request, "meeting/session_details.html",
879-
{ 'session':sessions[0] ,
880-
'meeting' :meeting ,
881-
'acronym' :acronym,
882-
'time': scheduled_time,
883-
'filtered_sessionpresentation_set': filtered_sessionpresentation_set
884-
})
885-
else:
886-
return render(request, "meeting/session_list.html",
887-
{ 'sessions':sessions ,
888-
'meeting' :meeting ,
889-
'acronym' :acronym,
890-
})
852+
session.filtered_sessionpresentation_set = [p for p in session.sessionpresentation_set.all() if p.document.get_state_slug(p.document.type_id)!='deleted']
853+
854+
return render(request, "meeting/session_details.html",
855+
{ 'sessions':sessions ,
856+
'meeting' :meeting ,
857+
'acronym' :acronym,
858+
})

ietf/templates/meeting/session_details.html

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@
66

77
{% block content %}
88
{% origin %}
9-
<h1>{{ meeting }} : {{ acronym }} : {{ time }} </h1>
9+
<h1>{{ meeting }} : {{ acronym }}</h1>
1010

11-
{% if session.name %}
12-
<h2>{{ session.name }}</h2>
13-
{% endif %}
11+
{% for session in sessions %}
12+
<h2>{{ session.time }}{% if session.name %} : {{ session.name }}{% endif %}</h2>
1413

15-
{% if filtered_sessionpresentation_set %}
16-
<p>Materials:</p>
14+
{% if session.filtered_sessionpresentation_set %}
15+
<p>Materials:</p>
1716

18-
<ul>
19-
{% for pres in filtered_sessionpresentation_set %}
20-
<li><a href="{% url 'doc_view' name=pres.document.name rev=pres.rev%}">{{ pres.document.name }}-{{ pres.rev }}</a></li>
21-
{% endfor %}
22-
</ul>
23-
{% endif %}
17+
<ul>
18+
{% for pres in session.filtered_sessionpresentation_set %}
19+
<li><a href="{% url 'doc_view' name=pres.document.name rev=pres.rev%}">{{ pres.document.name }}-{{ pres.rev }}</a></li>
20+
{% endfor %}
21+
</ul>
22+
{% endif %}
23+
{% endfor %}
2424

2525
{% endblock %}

ietf/templates/meeting/session_list.html

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)