Skip to content

Commit 47cbb8c

Browse files
committed
Moved some explicit URLs from code and templates to settings (related to www6 cleanup).
- Legacy-Id: 16230
1 parent 94de3e0 commit 47cbb8c

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

ietf/iesg/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ def agenda(request, date=None):
192192
data = agenda_data(date)
193193

194194
if has_role(request.user, ["Area Director", "IAB Chair", "Secretariat"]):
195-
data["sections"]["1.1"]["title"] = data["sections"]["1.1"]["title"].replace("Roll call", '<a href="https://www6.ietf.org/iesg/internal/rollcall.txt">Roll Call</a>')
196-
data["sections"]["1.3"]["title"] = data["sections"]["1.3"]["title"].replace("minutes", '<a href="https://www6.ietf.org/iesg/internal/minutes.txt">Minutes</a>')
195+
data["sections"]["1.1"]["title"] = data["sections"]["1.1"]["title"].replace("Roll call", '<a href="%s">Roll Call</a>' % settings.IESG_ROLL_CALL_URL )
196+
data["sections"]["1.3"]["title"] = data["sections"]["1.3"]["title"].replace("minutes", '<a href="%s">Minutes</a>' % settings.IESG_MINUTES_URL)
197197

198198
request.session['ballot_edit_return_point'] = request.path_info
199199
return render(request, "iesg/agenda.html", {
@@ -283,7 +283,9 @@ def agenda_package(request, date=None):
283283
"date": data["date"],
284284
"sections": sorted(data["sections"].iteritems()),
285285
"roll_call": data["sections"]["1.1"]["text"],
286+
"roll_call_url": settings.IESG_ROLL_CALL_URL
286287
"minutes": data["sections"]["1.3"]["text"],
288+
"minutes_url": settings.IESG_MINUTES_URL
287289
"management_items": [(num, section) for num, section in data["sections"].iteritems() if "6" < num < "7"],
288290
}, content_type='text/plain')
289291

ietf/settings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,9 @@ def skip_unreadable_post(record):
603603
IPR_DOCUMENT_PATH = '/a/www/ietf-ftp/ietf/IPR/'
604604
IESG_TASK_FILE = '/a/www/www6/iesg/internal/task.txt'
605605
IESG_ROLL_CALL_FILE = '/a/www/www6/iesg/internal/rollcall.txt'
606+
IESG_ROLL_CALL_URL = 'https://www6.ietf.org/iesg/internal/rollcall.txt'
606607
IESG_MINUTES_FILE = '/a/www/www6/iesg/internal/minutes.txt'
608+
IESG_MINUTES_URL = 'https://www6.ietf.org/iesg/internal/minutes.txt'
607609
IESG_WG_EVALUATION_DIR = "/a/www/www6/iesg/evaluation"
608610
# Move drafts to this directory when they expire
609611
INTERNET_DRAFT_ARCHIVE_DIR = '/a/www/www6s/draft-archive'

ietf/templates/iesg/agenda_package.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
Contents:
44

55
1. Roll Call and Dial-In Instructions
6-
https://www6.ietf.org/iesg/internal/rollcall.txt
6+
{{ roll_call_url }}
77
2. Agenda
88
https://datatracker.ietf.org/iesg/agenda/
99
3. Management Item Details
1010
https://datatracker.ietf.org/iesg/agenda/#6
1111
4. Previous minutes
12-
https://www6.ietf.org/iesg/internal/minutes.txt
12+
{{ minutes_url }}
1313

1414
------------------------------------------------------------------------
1515
1. ROLL CALL AND DIAL-IN INSTRUCTIONS

0 commit comments

Comments
 (0)