Skip to content

Commit 46e169d

Browse files
committed
Reordering entries of submission forms and notification emails to be more appropriate.
- Legacy-Id: 3094
1 parent 279679a commit 46e169d

4 files changed

Lines changed: 20 additions & 16 deletions

File tree

ietf/templates/submit/draft_edit.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ <h3>Adjust data</h3>
111111
<tr{% if form.errors.title %} class="warning"{% endif %}><th>Title</th><td>{{ form.title }}{{ form.errors.title }}</td></tr>
112112
<tr{% if form.errors.version %} class="warning"{% endif %}><th>Version</th><td>{{ form.version }}{{ form.errors.version }}</td></tr>
113113
<tr{% if form.errors.creation_date %} class="warning"{% endif %}><th>Creation date</th><td>{{ form.creation_date }}{{ form.errors.creation_date }}</td></tr>
114-
<tr{% if form.errors.pages %} class="warning"{% endif %}><th>Pages</th><td>{{ form.pages }}{{ form.errors.pages }}</td></tr>
115114
<tr{% if form.errors.abstract %} class="warning"{% endif %}><th>Abstract</th><td>{{ form.abstract }}{{ form.errors.abstract }}</td></tr>
115+
<tr{% if form.errors.pages %} class="warning"{% endif %}><th>Pages</th><td>{{ form.pages }}{{ form.errors.pages }}</td></tr>
116116
<tr><th>Submitter</th>
117117
<td>
118118
If you are one of the authors, then please click a button by your name to automatically fill in the submitter's information as requested below. Otherwise, Please manually enter your information.<br />

ietf/templates/submit/draft_status.html

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,16 +138,17 @@ <h3>Meta-Data errors found</h3>
138138
{% endif %}
139139

140140
<table class="metadata-table">
141-
<tr><th>Document</th><td>{{ detail.filename }} <a class="twopages_trigger" href="#">[View first two pages]</a>
141+
<tr><th>Document</th><td>
142+
{% ifequal status.status_value "Posted" %}<a href="http://www.ietf.org/id/{{ detail.filename }}-{{detail.revision}}.txt">{{ detail.filename }}</a>{% else %}{{ detail.filename }}{% endifequal %}
143+
<br/><a class="twopages_trigger" href="#">[View first two pages]</a>
142144
{% show_submission_files detail %}
143145
</td></tr>
144146
<tr{% if validation.warnings.revision %} class="warning"{% endif %}><th>Revision</th><td>{{ detail.revision }}<div class="warn_message">{{ validation.warnings.revision }}{% if validation.warnings.revision %}<br /><a class="twopages_trigger" href="#">[View error]</a>{% endif %}</div></td></tr>
147+
<tr{% if validation.warnings.group %} class="warning"{% endif %}><th>WG</th><td>{{ validation.wg|default:"Individual Submission" }}<div class="warn_message">{{ validation.warnings.group }}</div></td></tr>
148+
<tr{% if validation.warnings.creation_date %} class="warning"{% endif %}><th>Document date</th><td>{{ detail.creation_date }}<div class="warn_message">{{ validation.warnings.creation_date }}</div></td></tr>
145149
<tr><th>Submission date</th><td>{{ detail.submission_date }}</td></tr>
146150
<tr><th>Title</th><td>{{ detail.id_document_name }}</td></tr>
147-
<tr{% if validation.warnings.group %} class="warning"{% endif %}><th>WG</th><td>{{ validation.wg|default:"Individual Submission" }}<div class="warn_message">{{ validation.warnings.group }}</div></td></tr>
148-
<tr><th>File size</th><td>{{ detail.filesize|filesizeformat }}</td></tr>
149-
<tr{% if validation.warnings.creation_date %} class="warning"{% endif %}><th>Creation date</th><td>{{ detail.creation_date }}<div class="warn_message">{{ validation.warnings.creation_date }}</div></td></tr>
150-
<tr{% if validation.warnings.authors %} class="warning"{% endif %}><th colspan="2">Author(s) information</th></tr>
151+
<tr{% if validation.warnings.authors %} class="warning"{% endif %}><th colspan="2">Author information</th></tr>
151152
{% if validation.warnings.authors %}
152153
<tr class="warning"><td colspan="2"><div class="warn_message">{{ validation.warnings.authors|safe }}</div></td></tr>
153154
{% endif %}
@@ -156,8 +157,9 @@ <h3>Meta-Data errors found</h3>
156157
<tr{% if validation.warnings.authors %} class="warning"{% endif %}><th class="author">Author {{ forloop.counter }}</th><td>{{ author.get_full_name }} {% if author.email.1 %}&lt;{{ author.email.1 }}&gt;{% endif %}</td></tr>
157158
{% endfor %}
158159
{% endif %}
159-
<tr{% if validation.warnings.pages %} class="warning"{% endif %}><th>Pages</th><td>{{ detail.txt_page_count }}<div class="warn_message">{{ validation.warnings.pages }}</div></td></tr>
160160
<tr{% if validation.warnings.abstract %} class="warning"{% endif %}><th>Abstract</th><td>{{ detail.abstract|linebreaksbr }}<div class="warn_message">{{ validation.warnings.abstract }}</div></td></tr>
161+
<tr{% if validation.warnings.pages %} class="warning"{% endif %}><th>Pages</th><td>{{ detail.txt_page_count }}<div class="warn_message">{{ validation.warnings.pages }}</div></td></tr>
162+
<tr><th>File size</th><td>{{ detail.filesize|filesizeformat }}</td></tr>
161163
</table>
162164

163165
{% if allow_edit %}

ietf/templates/submit/manual_post_mail.txt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
1-
Manual Posting Requested for the following Internet-Draft:
1+
Manual posting has been requested for the following Internet-Draft:
22

33
I-D Submission Tool URL: http://{{ domain }}/submit/status/{{ draft.submission_id }}/
44

55
File name: {{ draft.filename }}
6+
Version: {{ draft.revision }}
67
Submission date: {{ draft.submission_date }}
78
WG: {{ draft.group_acronym|default:"Individual Submission" }} {% if form.validation.warnings.group %}*Please note that this WG is not an active one*{% endif %}
8-
File size: {{ draft.filesize|filesizeformat }}
99

1010
Title: {{ draft.id_document_name }}
11-
Version: {{ draft.revision }}
12-
Creation date: {{ draft.creation_date }}
13-
Pages: {{ draft.txt_page_count }}
11+
Document date: {{ draft.creation_date }}
1412
Abstract: {{ draft.abstract }}
13+
Pages: {{ draft.txt_page_count }}
14+
File size: {{ draft.filesize|filesizeformat }}
15+
1516
Submitter: {{ form.cleaned_data.first_name }} {{ form.cleaned_data.last_name }} <{{ form.cleaned_data.email }}>
1617

1718
Author(s):

ietf/templates/submit/submission_approval.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@ WG chair approval is needed for posting of {{ draft.filename }}-{{ draft.revisio
33
I-D Submission Tool URL: http://{{ domain }}/submit/status/{{ draft.submission_id }}/
44

55
File name: {{ draft.filename }}
6+
Version: {{ draft.revision }}
67
Submission date: {{ draft.submission_date }}
78
WG: {{ draft.group_acronym|default:"Individual Submission" }}
8-
File size: {{ draft.filesize|filesizeformat }}
99

1010
Title: {{ draft.id_document_name }}
11-
Version: {{ draft.revision }}
12-
Creation date: {{ draft.creation_date }}
13-
Pages: {{ draft.txt_page_count }}
11+
Document date: {{ draft.creation_date }}
1412
Abstract: {{ draft.abstract }}
13+
Pages: {{ draft.txt_page_count }}
14+
File size: {{ draft.filesize|filesizeformat }}
15+
1516
Submitter: {{ submitter.first_name }} {{ submitter.last_name }} <{{ submitter.email_address }}>
1617

1718
Author(s):

0 commit comments

Comments
 (0)